perf(share): Remove useless order by id#59753
Open
CarlSchwan wants to merge 3 commits intomasterfrom
Open
Conversation
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
sorbaugh
and removed request for
a team
Altahrim
reviewed
Apr 22, 2026
| @@ -388,8 +388,7 @@ public function getChildren(IShare $parent): array { | |||
| ], IQueryBuilder::PARAM_INT_ARRAY) | |||
| ) | |||
| ) | |||
| ->andWhere($qb->expr()->in('item_type', $qb->createNamedParameter(['file', 'folder'], IQueryBuilder::PARAM_STR_ARRAY))) | |||
| ->orderBy('id'); | |||
| ->andWhere($qb->expr()->in('item_type', $qb->createNamedParameter(['file', 'folder'], IQueryBuilder::PARAM_STR_ARRAY))); | |||
Collaborator
There was a problem hiding this comment.
It can also be dropped, there is no other option
Member
|
Failing unit tests proof my point 🙈 |
nickvergessen
added
2. developing
This should improve a bit the performance in some particular cases Signed-off-by: Carl Schwan <carlschwan@kde.org>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
work/carl/remove-orderById
branch
from
36bbc1b to
0d79ac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This should improve a bit the performance in some particular cases
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)