[stable31] fix(files_sharing): Restore password guard return for new public shares#59896
Merged
[stable31] fix(files_sharing): Restore password guard return for new public shares#59896
Conversation
fix(files_sharing): Restore password guard return for new public shares Creating a new public share without a password silently succeeded: the password error was shown but execution continued, and the share was created without a password. Users had to save a second time for the password to apply. The password guard now blocks the save when a new public share is missing a password. Non-public shares (user/group) are never blocked by this guard, so they remain unaffected. Tests invoke the real saveShare method against a stubbed context and cover the save-twice symptom and the non-public-share regression. Signed-off-by: nfebe <fenn25.fn@gmail.com> [skip ci]
nfebe
approved these changes
Apr 23, 2026
Contributor
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59873
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.