fix(Files/Cache): align MoveFromCacheTrait fallback validation with Cache::moveFromCache#59916
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
fix(Files/Cache): align MoveFromCacheTrait fallback validation with Cache::moveFromCache#59916joshtrichards wants to merge 2 commits intomasterfrom
MoveFromCacheTrait fallback validation with Cache::moveFromCache#59916joshtrichards wants to merge 2 commits intomasterfrom
Conversation
…e source entry Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
Author
|
An side: Since it is only used in production by I was initially confused about its use case, since no production code uses the trait other than |
Signed-off-by: Josh <josh.t.richards@gmail.com>
MoveFromCacheTrait fallback validation with Cache::moveFromCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the source cache entry in
MoveFromCacheTrait::moveFromCache()before attempting the fallback copy-then-delete move.Why
The fallback path should fail consistently when the source entry does not exist, rather than relying on a less specific downstream failure. This also keeps the trait behavior aligned with
Cache::moveFromCache().Behavior change
Low risk:
moveFromCache()now throws a clearerRuntimeExceptionimmediately.Cache::moveFromCache().TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)