feat(ldap): Allow to search one user by one of its LDAP attribute#59928
Open
CarlSchwan wants to merge 1 commit intomasterfrom
Open
feat(ldap): Allow to search one user by one of its LDAP attribute#59928CarlSchwan wants to merge 1 commit intomasterfrom
CarlSchwan wants to merge 1 commit intomasterfrom
Conversation
CarlSchwan
added
3. to review
CarlSchwan
requested review from
come-nc,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/ldap-search-one-by-attribute
branch
from
f8d70a0 to
15f4ff4
Compare
2 tasks
come-nc
requested changes
Apr 28, 2026
| @@ -0,0 +1,18 @@ | |||
| <?php | |||
|
|
|||
|
|
||
| #[Override] | ||
| public function getUserFromCustomAttribute(string $attribute, string $searchTerm): ?IUser { | ||
| $searchTerm = $this->access->escapeFilterPart($searchTerm); |
Contributor
There was a problem hiding this comment.
Should $attribute be escaped or validated 🤔
| $records = $this->access->searchUsers($filter, ['dn']); | ||
| if (count($records) === 1) { | ||
| $ldapUser = $this->access->userManager->get($records[0]['dn'][0]); | ||
| return $this->userManager->get($ldapUser->getUsername()); |
Contributor
There was a problem hiding this comment.
This should return the uid as a string to be consistent with the rest of the class and avoid having to inject UserManager in there.
Then LDAPProvider can wrap the UID in an IUser using IUserManager->getExistingUser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #55284
Alternative to #56721
Related PRs:
Checklist
3. to review, feature component)stable32)AI (if applicable)