Skip to content

Spelling fixes#60316

Merged
artonge merged 1 commit into
nextcloud:masterfrom
Justinzobel:work/justinzobel/spellingfixes
May 27, 2026
Merged

Spelling fixes#60316
artonge merged 1 commit into
nextcloud:masterfrom
Justinzobel:work/justinzobel/spellingfixes

Conversation

@Justinzobel

Copy link
Copy Markdown

Summary

Spelling fixes only

@Justinzobel Justinzobel requested review from a team and skjnldsv as code owners May 12, 2026 02:55
@Justinzobel Justinzobel requested review from ArtificialOwl, CarlSchwan, icewind1991, sorbaugh and susnux and removed request for a team May 12, 2026 02:55

@kesselb kesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@kesselb

kesselb commented May 12, 2026

Copy link
Copy Markdown
Contributor

Hi @Justinzobel,

To make our CI happy you need to reword the commit message from "Spelling fixes" to include a scope. For example fix: Spelling fixes. Even better if you can make the commit message bit more verbose like fix: "than" vs "then" typos.

If you dont want to bother for such a small change, please ping me an I'm going to cherry-pick your commit.

@Justinzobel Justinzobel force-pushed the work/justinzobel/spellingfixes branch from addf22c to 4ff6af1 Compare May 12, 2026 23:41
@Justinzobel

Copy link
Copy Markdown
Author

@kesselb fixed, thanks.

@susnux susnux added the bug label May 19, 2026
@susnux

susnux commented May 19, 2026

Copy link
Copy Markdown
Contributor

@Justinzobel you need to signoff your commit to accept the https://developercertificate.org/
So that easiest is git commit --amend -s

see also https://github.com/nextcloud/server/?tab=contributing-ov-file#sign-your-work

Signed-off-by: Justin Zobel <justin.zobel@gmail.com>
@Justinzobel Justinzobel force-pushed the work/justinzobel/spellingfixes branch from 4ff6af1 to 5619cc0 Compare May 20, 2026 03:09
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@artonge artonge merged commit da7c4ef into nextcloud:master May 27, 2026
193 of 200 checks passed
@welcome

welcome Bot commented May 27, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger

Copy link
Copy Markdown
Member

/backport to stable34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants