Skip to content

test(filesdrop): fix duplicate scenario titles, indentation, and add clarifying comments#60467

Merged
CarlSchwan merged 1 commit into
masterfrom
jtr/test-filedrop-review
Jun 8, 2026
Merged

test(filesdrop): fix duplicate scenario titles, indentation, and add clarifying comments#60467
CarlSchwan merged 1 commit into
masterfrom
jtr/test-filedrop-review

Conversation

@joshtrichards

Copy link
Copy Markdown
Member

Summary

Improves readability and correctness of filesdrop.feature without changing any test logic at this time.

  • Rename two pairs of duplicate scenario titles (Put same file multiple times and invalid nickname with forbidden characters) so test reports are unambiguous
  • Fix mixed tab/space indentation throughout the file
  • Add a feature-level comment explaining the shareType 3 vs 4 split
  • Add inline comments explaining the deduplication priority rules in the folder-vs-file conflict scenarios
  • Add comments clarifying the 405 vs 404 distinction in the "prevents GET" scenario
  • Document why dot-prefixed and .htaccess nicknames are blocked

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…clarifying comments

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone May 15, 2026
@joshtrichards joshtrichards requested a review from a team as a code owner May 15, 2026 21:09
@joshtrichards joshtrichards requested review from icewind1991 and salmart-dev and removed request for a team May 15, 2026 21:09
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label May 15, 2026
@susnux susnux added the bug label May 19, 2026
@CarlSchwan CarlSchwan merged commit 26cf308 into master Jun 8, 2026
173 of 182 checks passed
@CarlSchwan CarlSchwan deleted the jtr/test-filedrop-review branch June 8, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants