refactor: Remove most usages of IAppContainer and IServerContainer#60780
Open
CarlSchwan wants to merge 1 commit into
Open
refactor: Remove most usages of IAppContainer and IServerContainer#60780CarlSchwan wants to merge 1 commit into
CarlSchwan wants to merge 1 commit into
Conversation
CarlSchwan
force-pushed
the
carl/modernize-containers
branch
3 times, most recently
from
d08f117 to
aed4795
Compare
And port more stuff to standard ContainerInterface interface Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/modernize-containers
branch
from
aed4795 to
7d2081f
Compare
CarlSchwan
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
nickvergessen and
tcitworld
as code owners
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
provokateurin
requested changes
May 28, 2026
Comment on lines
+728
to
+730
| /** @var IAppContainer $appContainer */ | ||
| $appContainer = $apps[$appId] | ||
| ->getContainer(); |
Member
There was a problem hiding this comment.
This var annotation should not be needed. I suspect that the param type needs to be array<string, App>, so that psalm understands the value returned.
Comment on lines
+804
to
+806
| /** @var IContainer $appContainer */ | ||
| $appContainer = $apps[$appId] | ||
| ->getContainer(); |
Comment on lines
+830
to
+832
| /** @var IContainer $appContainer */ | ||
| $appContainer = $apps[$appId] | ||
| ->getContainer(); |
Comment on lines
+855
to
+857
| /** @var IContainer $appContainer */ | ||
| $appContainer = $apps[$appId] | ||
| ->getContainer(); |
Comment on lines
+962
to
+965
| $this->logger->error('User logged out', [ | ||
| 'exception' => new \RuntimeException('Logout'), | ||
| 'app' => 'core', | ||
| ]); |
| protected $systemConfig; | ||
| protected ContainerInterface&MockObject $c; | ||
| protected LogFactory $factory; | ||
| protected SystemConfig|MockObject $systemConfig; |
Member
There was a problem hiding this comment.
Suggested change
| protected SystemConfig|MockObject $systemConfig; | |
| protected SystemConfig&MockObject $systemConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)