Skip to content

docs(appframework): clarify PasswordConfirmationRequired behavior in docblocks#60783

Merged
Altahrim merged 3 commits into
masterfrom
jtr/docs-PwConfirmationRequired
Jun 11, 2026
Merged

docs(appframework): clarify PasswordConfirmationRequired behavior in docblocks#60783
Altahrim merged 3 commits into
masterfrom
jtr/docs-PwConfirmationRequired

Conversation

@joshtrichards

@joshtrichards joshtrichards commented May 27, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Clarify the PasswordConfirmationRequired docblocks to better reflect actual middleware behavior.

Changes:

  • document that password confirmation is required only when supported by the active authentication backend
  • clarify that enforcement behavior is handled by the password confirmation middleware
  • explain the difference between non-strict and strict modes
  • document that non-strict mode relies on a recent prior confirmation
  • add clearer wording for the strict constructor parameter and getStrict()

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@joshtrichards joshtrichards added this to the Nextcloud 35 milestone May 27, 2026
@joshtrichards joshtrichards marked this pull request as ready for review May 27, 2026 16:49
@joshtrichards joshtrichards requested a review from a team as a code owner May 27, 2026 16:49
@joshtrichards joshtrichards requested review from CarlSchwan, artonge, come-nc and provokateurin and removed request for a team May 27, 2026 16:49
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards force-pushed the jtr/docs-PwConfirmationRequired branch from 4ce1bc6 to 5d3c91a Compare May 29, 2026 15:42
@susnux susnux added the community pull requests from community label Jun 9, 2026
@Altahrim Altahrim merged commit 46a8117 into master Jun 11, 2026
184 of 197 checks passed
@Altahrim Altahrim deleted the jtr/docs-PwConfirmationRequired branch June 11, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants