[stable31] fix(assets): rebuild dist for stable31 with correct dependencies#60790
Open
miaulalala wants to merge 2 commits into
Open
[stable31] fix(assets): rebuild dist for stable31 with correct dependencies#60790miaulalala wants to merge 2 commits into
miaulalala wants to merge 2 commits into
Conversation
The dist files merged in #60621 were built using master's node_modules, which had @nextcloud/dialogs@7.3.0. That version bundles a Vue 3-compiled floating-vue/vue-resize that imports withScopeId, openBlock, createBlock from 'vue'. Vue 2.7.16 (used in stable31) does not export these APIs, causing a TypeError on page load that crashed all Cypress tests. Rebuilt using stable31's package-lock.json (@nextcloud/dialogs@6.4.2) with Node 20 as required by the project's engine constraint. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
github-actions
Bot
changed the title
miaulalala
requested review from
a team,
ChristophWurst,
mejo-,
nfebe and
sorbaugh
and removed request for
a team
miaulalala
added
bug
3. to review
Member
|
Seems like still all Cypress tests fail 😢 |
The Cypress browser (Chrome 118 / Electron 27) is below stable31's minimum browser version requirement, causing every page visit to show "Your browser is not supported" instead of loading the app. This silently prevented #user-menu, [data-cy-files-list], OCA.Files.Sidebar, and all other Vue-rendered elements from ever appearing, making the entire test suite fail. Set no_unsupported_browser_warning=true during configureNextcloud() so the browser check is suppressed in the test container. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/noid/stable31-comments-dist-rebuild
branch
from
ba0232c to
faa005f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: (0 , _.withScopeId) is not a functionnode_modules, which had@nextcloud/dialogs@7.3.0@nextcloud/dialogs@7.3.0bundles a Vue 3-compiledfloating-vue/vue-resizethat importswithScopeId,openBlock, andcreateBlockfromvueTypeErroron every page load → all Cypress tests failThis PR rebuilds the dist files using stable31's
package-lock.json(@nextcloud/dialogs@6.4.2) with Node 20 as required by the project's engine constraint.Test plan
🤖 Generated with Claude Code