docs(IRequest): streamline duplicate docs + update for clarity and accuracy#60889
Open
joshtrichards wants to merge 15 commits into
Open
docs(IRequest): streamline duplicate docs + update for clarity and accuracy#60889joshtrichards wants to merge 15 commits into
joshtrichards wants to merge 15 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Oh and slighly refactor getHeader() since this was tied to some other work that lead to this cleanup. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…arameter set methods Signed-off-by: Josh <josh.t.richards@gmail.com>
…riever methods Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…arity Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim and
leftybournes
and removed request for
a team
joshtrichards
changed the title
CarlSchwan
approved these changes
Jun 1, 2026
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Copilot stopped work on behalf of
joshtrichards due to an error
June 1, 2026 16:53
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The implementation duplicated a lot of function-level docblocks that were already in the interface. A few were also only in the implementation. In addition, some was inaccurate, extraneous, or unclear.
Changes:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)