docs(App): drop/update outdated {OC, OCP}\AppFramework\App docblocks #60902
docs(App): drop/update outdated {OC, OCP}\AppFramework\App docblocks #60902joshtrichards wants to merge 3 commits into
{OC, OCP}\AppFramework\App docblocks #60902Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
|
Hello, Thanks for the work though I’m gonna close this one. Also this reads like LLM-assisted, in which case you need to check the box and say so, see https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#ai-assisted-contributions |
Hi @come-nc, thanks for the review and for taking a look. I understand the concern about working on deprecated or internal APIs. My thinking here was mainly that In particular, I wanted to remove the long For the deprecated pieces, only part of the PR touches deprecated methods, so my intent was just to make the existing docs clearer while those methods remain in the codebase, especially since they were only deprecated in v34. The current On changing "must inherit" to "typically extend", my intent was to make the terminology more precise. "Extend" matches the wording used in the Developer Manual, and since this is standard class inheritance rather than interface implementation, it seemed like the more accurate term. That said, "must extend" would likely be clearer, and I’d be happy to adjust that. As a secondary point, I also thought some of the I’ll reply separately on the AI checkbox point as well, since it's a separate meta-issue. |
Summary
TODO
OCP\AppFramework\App::dispatch()could/should be deprecated and/or better documented (from what I can tell it was part of the old approach to adding controller routes inroutes.phpunless I'm thinking about this entirely wrong).Checklist
3. to review, feature component)stable32)AI (if applicable)