test: Warn about slow startup time for phpunit tests#61141
Merged
Conversation
artonge
requested review from
CarlSchwan,
come-nc,
icewind1991 and
provokateurin
and removed request for
a team
CarlSchwan
approved these changes
Jun 10, 2026
come-nc
approved these changes
Jun 10, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Should we revert the logic and have a ENABLECOVERAGE switch instead?
Altahrim
approved these changes
Jun 10, 2026
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/test/warn_about_slow_startup_time
branch
from
3d138ed to
f2b91fc
Compare
Collaborator
Author
|
I inverted the behaviour, we now don't generate coverage by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Else the startup time takes more than ten seconds for each run.