Skip to content

test(files): migrate favorites e2e from Cypress to Playwright#61145

Merged
CarlSchwan merged 1 commit into
masterfrom
test/migrate-favorites-playwright
Jun 10, 2026
Merged

test(files): migrate favorites e2e from Cypress to Playwright#61145
CarlSchwan merged 1 commit into
masterfrom
test/migrate-favorites-playwright

Conversation

@pringelmann

@pringelmann pringelmann commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrate the favorites e2e spec from cypress to playwright. Covers favoriting/unfavoriting a file from the row actions, seeing a favorited folder appear in the navigation, and favoriting/unfavoriting from the sidebar.

Adds the supporting page objects: a new FilesNavigationPage for the left-hand view list, plus sidebar helpers and a row action-menu split so a test can read a menu label before clicking.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly generated using AI

@pringelmann pringelmann self-assigned this Jun 10, 2026
@pringelmann pringelmann added tests Related to tests CI labels Jun 10, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the test/migrate-favorites-playwright branch from b42a093 to 87f8d78 Compare June 10, 2026 10:12
@pringelmann pringelmann added this to the Nextcloud 35 milestone Jun 10, 2026
@pringelmann pringelmann marked this pull request as ready for review June 10, 2026 10:17
@pringelmann pringelmann requested a review from a team as a code owner June 10, 2026 10:17
@pringelmann pringelmann requested review from nfebe, sorbaugh and susnux and removed request for a team June 10, 2026 10:17
@pringelmann pringelmann added the 3. to review Waiting for reviews label Jun 10, 2026
@pringelmann pringelmann force-pushed the test/migrate-favorites-playwright branch from ad93216 to 87f8d78 Compare June 10, 2026 11:47
@pringelmann pringelmann requested a review from artonge June 10, 2026 12:48
@CarlSchwan CarlSchwan merged commit 6fc428a into master Jun 10, 2026
300 of 385 checks passed
@CarlSchwan CarlSchwan deleted the test/migrate-favorites-playwright branch June 10, 2026 15:38

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@artonge artonge removed the CI label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants