Skip to content

[stable33] fix: Return type error after #60844 #61199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artonge wants to merge 1 commit into from
Closed

[stable33] fix: Return type error after #60844 #61199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/public/Files/Search/ISearchQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function limitToHome(): bool;
/**
* The fields to include in the search results
*
* @return list<string>
* @return array

@CarlSchwan CarlSchwan Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds wrong. the new type is less strict

@artonge artonge Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is:

Error: lib/private/Files/Search/SearchQuery.php:98:37: MoreSpecificReturnType: The declared return type 'list<string>' for OC\Files\Search\SearchQuery::getSelectFields is more specific than the inferred return type 'array<array-key, mixed>' (see https://psalm.dev/070)

Not sure what would be the best solution for that, it is not an issue in more recent versions as the return property is typed slightly differently

* @since 33.0.6
*/
public function getSelectFields(): array;
Expand Down
Loading