Skip to content

test(files): migrate files download e2e from Cypress to Playwright#61223

Open
pringelmann wants to merge 1 commit into
masterfrom
test/migrate-files-download-playwright
Open

test(files): migrate files download e2e from Cypress to Playwright#61223
pringelmann wants to merge 1 commit into
masterfrom
test/migrate-files-download-playwright

Conversation

@pringelmann

@pringelmann pringelmann commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrates the files download spec to Playwright.

The main difference from the Cypress version is download capture: instead of reading a file off a configured downloads folder, the spec listens for Playwright's download event and asserts on suggestedFilename() plus the downloaded body.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes — n/a, test-only change
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable — n/a, master-only test infra
  • Labels added where applicable (ex: tests, 3. to review)
  • Milestone added for target branch/version

AI

  • The content of this PR was partly generated using AI

@pringelmann pringelmann added this to the Nextcloud 35 milestone Jun 11, 2026
@pringelmann pringelmann self-assigned this Jun 11, 2026
@pringelmann pringelmann added tests Related to tests CI labels Jun 11, 2026
Comment thread tests/playwright/e2e/files/files-download.spec.ts Dismissed
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann force-pushed the test/migrate-files-download-playwright branch from 5c883ae to 3e2100b Compare June 11, 2026 21:45
@pringelmann pringelmann marked this pull request as ready for review June 12, 2026 10:46
@pringelmann pringelmann requested a review from a team as a code owner June 12, 2026 10:46
@pringelmann pringelmann requested review from nfebe, sorbaugh and susnux and removed request for a team June 12, 2026 10:46
@susnux susnux added the 3. to review Waiting for reviews label Jun 12, 2026

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@susnux susnux requested review from CarlSchwan and artonge June 12, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews CI tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants