fix(files_sharing): remove leading slash from filename on unshare toast#61303
Merged
leftybournes merged 2 commits intoJun 23, 2026
Merged
Conversation
leftybournes
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
CarlSchwan
approved these changes
Jun 18, 2026
leftybournes
force-pushed
the
leftybournes/fix/sharing-remove-slash-on-unshare-toast
branch
from
69b5711 to
12c0329
Compare
leftybournes
changed the title
susnux
approved these changes
Jun 22, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
So basically this removed the root / of the path.
Fine with it if it is confusing for users.
kra-mo
approved these changes
Jun 22, 2026
kra-mo
left a comment
kra-mo
left a comment
Member
There was a problem hiding this comment.
Makes sense, users are not often exposed to this.
Still, doing this as a one-off is never nice, I wonder where else we could do this. Then it could just be displayPath or something.
Signed-off-by: Kent Delante <kent@delante.me>
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
force-pushed
the
leftybournes/fix/sharing-remove-slash-on-unshare-toast
branch
from
12c0329 to
5b6139c
Compare
Member
Author
|
/backport 046de32 to stable34 |
Member
Author
|
/backport 046de32 to stable33 |
Member
Author
|
/backport 046de32 to stable32 |
leftybournes
deleted the
leftybournes/fix/sharing-remove-slash-on-unshare-toast
branch
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when a file/folder is unshared, the confirmation toast shows the filename with a slash (e.g. File "/Notes.txt" has been unshared). This fixes it so that it no longer contains a slash (e.g. File "Notes.text" has been unshared).
Checklist
3. to review, feature component)stable32)AI (if applicable)