Skip to content

[stable34] chore(ci): Remove code coverage from stable branches#61335

Merged
artonge merged 3 commits into
stable34from
fix/remove-phpunit-coverage-in-stable34
Jun 16, 2026
Merged

[stable34] chore(ci): Remove code coverage from stable branches#61335
artonge merged 3 commits into
stable34from
fix/remove-phpunit-coverage-in-stable34

Conversation

@come-nc

@come-nc come-nc commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc self-assigned this Jun 16, 2026
@come-nc come-nc requested a review from a team as a code owner June 16, 2026 12:53
@come-nc come-nc requested review from Altahrim and ArtificialOwl and removed request for a team June 16, 2026 12:53
@come-nc come-nc added the 3. to review Waiting for reviews label Jun 16, 2026
@come-nc come-nc requested review from nfebe and salmart-dev June 16, 2026 12:53
@come-nc come-nc added this to the Nextcloud 34.0.1 milestone Jun 16, 2026
@come-nc come-nc changed the title chore(ci): Remove code coverage from stable branches [stable34] chore(ci): Remove code coverage from stable branches Jun 16, 2026
@come-nc

come-nc commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

php8.4-s3 is super flaky, looks like it was not the case on PHP 8.3 🤔

@come-nc

come-nc commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author
		if (str_starts_with(PHP_VERSION, '8.3') && getenv('CI')) {
			$this->markTestSkipped('Test is unreliable and skipped on 8.3');
		}

The test was skipped on 8.3

@come-nc

come-nc commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@come-nc

come-nc commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

The failures are not related, cypress is unrelated and PHPUnit OCI are timeouts. I will try later to backport Anna’s fix for these timeouts as well.

@artonge artonge merged commit 6507116 into stable34 Jun 16, 2026
176 of 186 checks passed
@artonge artonge deleted the fix/remove-phpunit-coverage-in-stable34 branch June 16, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants