Skip to content

chore: Add debug to AlgorithmTest to debug flakiness #61491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
come-nc wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −0
Draft

chore: Add debug to AlgorithmTest to debug flakiness #61491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24d0b50
chore: Add debug to AlgorithmTest to debug flakiness
come-nc Jun 22, 2026
d203a26
tmp
come-nc Jun 22, 2026
1db7053
tmp
come-nc Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/private/Security/Signature/Rfc9421/Algorithm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,16 @@ public static function verify(string $signatureBase, string $signature, Key $key
throw new SignatureException('verifying Ed25519 signatures requires ext-sodium');
}
if (strlen($signature) !== SODIUM_CRYPTO_SIGN_BYTES) {
echo __LINE__ . " return false\n";
return false;
}
// parseKey hands OKP material as plain base64 of the 32 raw bytes.
$rawPublic = base64_decode((string)$material, true);
if ($rawPublic === false || strlen($rawPublic) !== SODIUM_CRYPTO_SIGN_PUBLICKEYBYTES) {
echo __LINE__ . " return false\n";
return false;
}
echo __LINE__ . " return ?\n";
return sodium_crypto_sign_verify_detached($signature, $signatureBase, $rawPublic);
}

Expand All @@ -102,10 +105,12 @@ public static function verify(string $signatureBase, string $signature, Key $key
if ($encoding === 'ecdsa') {
$signature = self::ecdsaRawToDer($signature, self::ecdsaCoordinateSize($resolved));
if ($signature === null) {
echo __LINE__ . " return false\n";
return false;
}
}

echo __LINE__ . ' return ' . openssl_verify($signatureBase, $signature, $material, $opensslAlgo) . "\n";
return openssl_verify($signatureBase, $signature, $material, $opensslAlgo) === 1;
}

Expand Down
5 changes: 5 additions & 0 deletions tests/lib/Security/Signature/Rfc9421/AlgorithmTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ public function testRsaPkcs1RoundTrip(): void {
public function testEcdsaP256RoundTrip(): void {
[$priv, $key] = $this->ecKeyPair('prime256v1', 'P-256', 'ES256');
$sig = Algorithm::sign('payload', $priv, 'ecdsa-p256-sha256');
echo "sig:$sig\n";
// echo "key:$key\n";
echo 'key:' . serialize($key) . "\n";
$this->assertSame(64, strlen($sig));
$this->assertTrue(Algorithm::verify('payload', $sig, $key, 'ecdsa-p256-sha256'));
$this->assertTrue(Algorithm::verify('payload', $sig, $key, 'ES256'));
Expand All @@ -96,6 +99,8 @@ public function testEcdsaP256RoundTrip(): void {
public function testEcdsaP384RoundTrip(): void {
[$priv, $key] = $this->ecKeyPair('secp384r1', 'P-384', 'ES384');
$sig = Algorithm::sign('payload', $priv, 'ecdsa-p384-sha384');
echo "sig:$sig\n";
echo 'key:' . serialize($key) . "\n";
$this->assertSame(96, strlen($sig));
$this->assertTrue(Algorithm::verify('payload', $sig, $key, 'ecdsa-p384-sha384'));
}
Expand Down
Loading