Skip to content

fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storage #61497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
provokateurin wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −10
Draft

fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storage #61497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e018956
refactor(ViewOnlyPlugin): Cleanup checks
provokateurin Jun 22, 2026
b8f1f7f
fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same s…
provokateurin Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions apps/dav/lib/DAV/ViewOnlyPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

namespace OCA\DAV\DAV;

use OCA\DAV\Connector\Sabre\Directory;
use OCA\DAV\Connector\Sabre\Exception\Forbidden;
use OCA\DAV\Connector\Sabre\File as DavFile;
use OCA\Files_Versions\Sabre\VersionFile;
Expand Down Expand Up @@ -93,17 +94,27 @@ public function checkViewOnly(RequestInterface $request): bool {
return true;
}

// We have two options here, if download is disabled, but viewing is allowed,
// we still allow the GET request to return the file content.
$canDownload = $attributes->getAttribute('permissions', 'download');
if (!$share->canSeeContent()) {
throw new Forbidden('Access to this shared resource has been denied because its download permission is disabled.');
}
switch ($request->getMethod()) {
case 'GET':
// If download is disabled, but viewing is allowed, we still allow the GET method to return the file content.
if (!$share->canSeeContent()) {
throw new Forbidden('Access to this shared resource has been denied because its download permission is disabled.');
}
break;
case 'COPY':
case 'MOVE':
$destination = $this->server->getCopyAndMoveInfo($request)['destination'];
$destinationParent = $this->server->tree->getNodeForPath(dirname($destination));
// Copy and move operations within the same storage are allowed, because the destination has the same restrictions.
if (($destinationParent instanceof Directory) && $destinationParent->getNode()->getStorage()->getId() === $storage->getId()) {
break;
}

// If download is disabled, we disable the COPY and MOVE methods even if the
// shareapi_allow_view_without_download is set to true.
if ($request->getMethod() !== 'GET' && ($canDownload !== null && !$canDownload)) {
throw new Forbidden('Access to this shared resource has been denied because its download permission is disabled.');
// If download is disabled, we disable the COPY and MOVE methods even if the shareapi_allow_view_without_download is set to true.
if (!$share->canDownload()) {
throw new Forbidden('Access to this shared resource has been denied because its download permission is disabled.');
}
break;
}
} catch (NotFound $e) {
// File not found
Expand Down
Loading