feat(share): add ShareReviewAccessCheckEvent to OCP public API#61543
Open
AndyScherzinger wants to merge 1 commit into
Open
feat(share): add ShareReviewAccessCheckEvent to OCP public API#61543AndyScherzinger wants to merge 1 commit into
AndyScherzinger wants to merge 1 commit into
Conversation
AndyScherzinger
requested review from
Altahrim and
ArtificialOwl
and removed request for
a team
Member
Author
|
/backport to stable34 |
CarlSchwan
reviewed
Jun 23, 2026
CarlSchwan
left a comment
CarlSchwan
left a comment
Member
There was a problem hiding this comment.
Need to run build/autoloaderchecker.sh
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
5 times, most recently
from
fa52514 to
c4ea0a9
Compare
Introduces OCP\Share\Events\ShareReviewAccessCheckEvent as the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/shareReviewDeleteEvent
branch
from
c4ea0a9 to
af59b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces OCP\Share\Events\ShareReviewAccessCheckEvent as the canonical authorization gate event for ShareReview sources. The event carries the source name and share ID for listener context, implements deny-wins semantics, and stops propagation immediately on denial.
This is a discussed and agreed on measure to safeguard auditing-triggered share deletions throughout various apps using a "check back event mechanism", so apps can implement their support for this (any app that has shares basically, of any kind)
Assisted-by: ClaudeCode:claude-sonnet-4-6
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)