fix: adjust file picker for background image to allow folder navigation#61688
Open
cristianscheid wants to merge 2 commits into
Open
fix: adjust file picker for background image to allow folder navigation#61688cristianscheid wants to merge 2 commits into
cristianscheid wants to merge 2 commits into
Conversation
cristianscheid
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
8 tasks
susnux
approved these changes
Jul 1, 2026
Contributor
|
If possible it would be really great to have a small PlayWright test for this |
artonge
approved these changes
Jul 1, 2026
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/58645/background-file-picker
branch
from
3fdc544 to
2763885
Compare
Member
Author
|
@susnux @pringelmann small test added. This is the first Playwright test I wrote, would appreciate some feedback. |
…ile picker Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/58645/background-file-picker
branch
from
2763885 to
07cdbe2
Compare
susnux
reviewed
Jul 2, 2026
| await expect.poll(async () => (await getBodyThemingSnapshot(page)).backgroundImage).toBe('none') | ||
| }) | ||
|
|
||
| test('User can pick a custom background from their files', async ({ page, user }) => { |
Contributor
There was a problem hiding this comment.
Looks good but maybe annotate this regression test:
Suggested change
| test('User can pick a custom background from their files', async ({ page, user }) => { | |
| test('User can pick a custom background from their files', { | |
| annotation: { type: 'issue', description: 'https://github.com/nextcloud/server/issues/58645' }, | |
| }, async ({ page, user }) => { |
pringelmann
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the file picker to change user background (under
settings/user/theming) does not allow to navigate folders when searching for a file. Instead, it only shows files from root directory on "All files" tab.This happens because of
setFilter((node) => node.mime.startsWith('image/')), which causes folders to be filtered out from results. This PR changes this line to usesetMimeTypeFilter(['image/*']), which allows to navigate folders while mantaining the filter to only allow image selection.Screenshots
Checklist
3. to review, feature component)stable32)AI (if applicable)