Store taskprocessing output files with extension to ease mimtype guessing

[marcelklehr]

Summary

Currently, we have to guess the mime type entirely from the data which is sometimes hard. With this we allow synchronous providers to hint the file extension and mime type.

Also adds some needed attributes.

TODO

• How should we allow ex apps to pass this information?

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) will be updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[julien-nc]

Lgtm 👍

[Copilot]

Pull request overview

This PR extends the TaskProcessing public API and implementation to better handle “file-shaped” task outputs by allowing providers (and ExApps uploads) to influence stored output filenames via extensions, with the goal of improving MIME type detection downstream. It also annotates several public TaskProcessing interfaces/data objects with #[Implementable] / #[Consumable] attributes.

Changes:

• Introduces OCP\TaskProcessing\FileShaped and updates synchronous provider return type annotations to allow returning FileShaped values.
• Extends output validation (EShapeType::validateOutputWithFileData) and output encapsulation (Manager::encapsulateOutputFileData) to accept file-shaped outputs.
• Appends file extensions when storing uploaded/provider output data in AppData, and adds Implementable/Consumable attributes to several public APIs.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
lib/public/TaskProcessing/SynchronousProviderOptions.php	Marks the options class as #[Consumable] for public API consumption.
lib/public/TaskProcessing/ShapeEnumValue.php	Marks the DTO as #[Consumable].
lib/public/TaskProcessing/ShapeDescriptor.php	Marks the DTO as #[Consumable].
lib/public/TaskProcessing/ITriggerableProvider.php	Marks provider interface as #[Implementable] (but since metadata needs correction).
lib/public/TaskProcessing/ITaskType.php	Marks task type interface as #[Implementable].
lib/public/TaskProcessing/ISynchronousProvider.php	Marks interface as #[Implementable] and expands psalm return types to include FileShaped.
lib/public/TaskProcessing/ISynchronousOptionsAwareProvider.php	Marks interface as #[Implementable] and expands psalm return types to include FileShaped.
lib/public/TaskProcessing/IProvider.php	Marks provider interface as #[Implementable].
lib/public/TaskProcessing/IInternalTaskType.php	Marks internal task type interface as #[Implementable] (minor formatting consistency).
lib/public/TaskProcessing/FileShaped.php	Adds new public DTO to carry file-shaped output data + metadata (extension/mime type).
lib/public/TaskProcessing/EShapeType.php	Updates output validation to allow FileShaped (but list validation currently has critical logic errors).
lib/private/TaskProcessing/Manager.php	Stores file outputs using provided extensions (but list branch currently clears unrelated output keys and needs extension normalization).
core/Controller/TaskProcessingApiController.php	Appends extension when storing ExApp uploaded files (needs extension sanitization/normalization).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[julien-nc]

Lgtm. A few nitpicks.

[kyteinsky]

Suggested change

	$ext = pathinfo($file['name'], PATHINFO_EXTENSION);
	$ext = pathinfo(($file['name'] ?? ''), PATHINFO_EXTENSION);

[kyteinsky]

maybe it would be nice to exact these checks in functions with separate ifs for different checks so they are easier to parse.
they could even be reused for the array checks then.

something along these lines but feel free to do it your way:

	/**
	 * Check whether a single value is valid file output data for the given shape type.
	 * Accepts raw string data or a FileShaped wrapper whose shape type matches.
	 */
	private static function isValidFileData(mixed $value, EShapeType $expected): bool {
		if (is_string($value)) {
			return true;
		}
		return $value instanceof FileShaped && $value->getShapeType() === $expected;
	}

	/**
	 * Check whether a value is a valid list of file output data items.
	 */
	private static function isValidFileDataList(mixed $value, EShapeType $scalarType): bool {
		if (!is_array($value)) {
			return false;
		}
		foreach ($value as $item) {
			if (!self::isValidFileData($item, $scalarType)) {
				return false;
			}
		}
		return true;
	}

and can be used like:

		if ($this === EShapeType::Image && !self::isValidFileData($value, EShapeType::Image)) {
			throw new ValidationException('Non-image item provided for Image slot');
		}

[kyteinsky]

Suggested change

	throw new ValidationException('Non-audio list item provided for ListOfFiles slot');
	throw new ValidationException('Non-file list item provided for ListOfFiles slot');

[kyteinsky]

maybe it can be noted that FileShaped addition in the return type was made in 35.0.0
like in

server/lib/public/TaskProcessing/IManager.php

Line 55 in 0258837

* @since 31.0.0 Added the `showDisabled` argument.

[kyteinsky]

the extension provider is within the trust boundary of ex-apps and php apps but it may not hurt to reject .php, .phar and .htaccess extensions