feat(core): header-anchored combobox shell for unified search#61849
Merged
Conversation
pringelmann
force-pushed
the
feat/search-combobox-shell
branch
from
f3b2846 to
aa0153e
Compare
pringelmann
force-pushed
the
feat/search-combobox-shell
branch
2 times, most recently
from
ce8d891 to
2048ec0
Compare
pringelmann
commented
Jul 7, 2026
| @media (min-width: 512px) { | ||
| #body-user & { | ||
| #body-user &, | ||
| #body-settings & { |
Contributor
Author
There was a problem hiding this comment.
Bugfix from subtask 1 PR
The settings page did not get the flex rule applied
pringelmann
commented
Jul 7, 2026
| * Implemented as a plain <input> rather than NcTextField/NcInputField: those | ||
| * assume a light form background and a floating label, which clashes with the | ||
| * themed header and the resting "button" look and would need heavy overrides of | ||
| * their internals. A custom input also lets us own the combobox semantics the |
Contributor
Author
There was a problem hiding this comment.
I do not want to couple the search bar to lib internals. It is a prominent feature on every page so the risk of even a minor change to upstream lib breaking the search is high. Custom input is therefore warranted here imo. Happy to debate
pringelmann
force-pushed
the
feat/search-combobox-shell
branch
2 times, most recently
from
75fc074 to
7eb222e
Compare
pringelmann
added
3. to review
pringelmann
requested review from
artonge,
kra-mo,
nfebe,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
feat/search-combobox-shell
branch
from
7eb222e to
a357887
Compare
susnux
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the header search into the a combobox shell. The header field is now a real combobox
<input>: you type into directly, and results show in a popover anchored under it instead of a centredNcDialog. Mobile collapses to a button that opens a full-height panel with anNcTextFieldinside.-> Preview link <-
The popover opens on the first character and closes when cleared (Ctrl+F opens it empty). Focusing the empty field doesn't open the popover.
Not in this PR: the search orchestration bugs (result flashing, no request cancellation, "load more") go to subtask 5, and the full combobox keyboard/a11y model goes to subtask 6. The shell just wires the input to the existing search results.
Why custom, not NC components:
#headeris its own stacking context and NcModal teleports tobody, so it can't sit below the in-header input while dimming the page (and it steals focus off the input). The input is a plain<input>because NcTextField assumes a light form background + floating label that clash with the themed header.focus-trapis already a dep and the panel reuses NcModal's exact styling so it still looks like a standard dialog. Mobile stays a plainsearchboxon purpose.Checklist
AI