Skip to content

perf(tags): reduce repeated query setup in hot loops#61856

Open
joshtrichards wants to merge 2 commits into
masterfrom
jtr/perf-Tags-getTagsForObjects
Open

perf(tags): reduce repeated query setup in hot loops#61856
joshtrichards wants to merge 2 commits into
masterfrom
jtr/perf-Tags-getTagsForObjects

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Jul 6, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Reduce a bit of repeated query setup and parameter binding in OC\Tags.

  • bind the invariant uid and type parameters once in getTagsForObjects(); loop only updates the chunk parameter
  • reuse a single relation-insert query builder in save()
  • bind the invariant relation type parameter once in save(); the loop only updates objid and categoryid

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Jul 6, 2026
@susnux susnux added the community pull requests from community label Jul 7, 2026
@CarlSchwan

Copy link
Copy Markdown
Member

LGTM

@joshtrichards joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 7, 2026
@joshtrichards joshtrichards marked this pull request as ready for review July 7, 2026 13:33
@joshtrichards joshtrichards requested a review from a team as a code owner July 7, 2026 13:33
@joshtrichards joshtrichards requested review from ArtificialOwl, icewind1991, leftybournes and salmart-dev and removed request for a team July 7, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants