fix(auth): confine OCM access token to the masked share endpoint#61870
Merged
Conversation
mickenordin
requested review from
ArtificialOwl and
leftybournes
and removed request for
a team
mickenordin
force-pushed
the
kano-ocm-token-confinement
branch
from
331ecd1 to
b2342d7
Compare
Gate the temporary-token bearer auth behind an allowOcmAccessToken flag that only the public, share-masked webdav endpoints set, and drop the BearerAuth backend from the CalDAV/CardDAV entrypoints. The token is now honored only on /public.php/webdav, where per-share masking applies. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Micke Nordin <kano@sunet.se>
mickenordin
force-pushed
the
kano-ocm-token-confinement
branch
from
b2342d7 to
db96073
Compare
provokateurin
approved these changes
Jul 7, 2026
CarlSchwan
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want to gate the temporary-token bearer behind an allowOcmAccessToken flag that only the public, share-masked webdav endpoints set, and drop the BearerAuth backend from the CalDAV/CardDAV entrypoints. The token is now honored only on /public.php/webdav, where per-share masking applies. Bearer auth is never used for contacts and calendar, anyway, so we remove it from there. If we want to move that to bearer auth in the future, we make adjustments that validates the token properly there at that time.
Checklist
3. to review, feature component)stable32)AI (if applicable)