chore(playwright): Wait for server response before checking sorting result

[DerDreschner]

Summary

This PR fixes a race condition that affects the playwright tests under high load on the CI runners. In case the race condition occurs, the tests fail with the following message:

Notice:   1 failed
    [chrome] › tests/playwright/e2e/files/files-sorting.spec.ts:138:2 › Files: Sorting the file list › Sorting works after switching view twice 
  43 passed (10.8m)

  1) [chrome] › tests/playwright/e2e/files/files-sorting.spec.ts:138:2 › Files: Sorting the file list › Sorting works after switching view twice 

    Error: expect(received).toEqual(expected) // deep equality

    - Expected  - 3
    + Received  + 3

      Array [
        "folder",
    -   "1 tiny.txt",
    -   "welcome.txt",
    -   "a medium.txt",
        "z big.txt",
    +   "a medium.txt",
    +   "welcome.txt",
    +   "1 tiny.txt",
      ]

    Call Log:
    - Timeout 15000ms exceeded while waiting on the predicate

      158 | 		await filesListPage.sortByColumn('Size')
      159 | 		await expect(filesListPage.getColumnHeader('Size')).toHaveAttribute('aria-sort', 'ascending')
    > 160 | 		await expect.poll(() => filesListPage.getRowNames()).toEqual([
          | 		                                                     ^
      161 | 			'folder',
      162 | 			'1 tiny.txt',
      163 | 			'welcome.txt',
        at /home/runner/actions-runner/_work/server/server/tests/playwright/e2e/files/files-sorting.spec.ts:160:56

    Error Context: test-results/files-files-sorting-Files--46f65--after-switching-view-twice-chrome/error-context.md

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[susnux]

If you pre-emit the event before the actual update you must handle the error case where the update failed and revert the config update.

[susnux]

This PR fixes a race condition that affects the playwright tests under high load on the CI runners.

If its only about the tests then make them wait for the PUT before continue. Should be an easy wait for response call.

[DerDreschner]

@susnux: I've changed the PR. I now wait for the response of the server in the test itself. I realized this is the best thing to do even if we would implement some kind of optimistic update here.

If its only about the tests then make them wait for the PUT before continue. Should be an easy wait for response call.

It kinda is, kinda not. You can trigger the race condition with slow servers and multiple clicks as well as only the last server response is the state being shown. Not the last thing the user did. But we don't have an optimistic UI approach here, so, I think it's the right thing to do. Although I think that's a pretty low-hanging fruit to make the files UI feel more smooth.