Skip to content

chore(playwright): Rewrite password confirmation handler to avoid race conditions #62033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Jul 14, 2026
+11 −12
Merged

chore(playwright): Rewrite password confirmation handler to avoid race conditions #62033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions tests/playwright/support/utils/password-confirmation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,18 @@

try {
// Check if the dialog exists within a short timeout
const dialogVisible = await dialog.isVisible({ timeout: 500 }).catch(() => false)

if (dialogVisible) {
// Fill the password field
await dialog.locator('input[type="password"]').fill(password)

// Click the confirm button
await dialog.getByRole('button', { name: 'Confirm' }).click()

// Wait for the dialog to disappear
await dialog.waitFor({ state: 'hidden' })
}
await dialog.waitFor({ state: 'visible', timeout: 500 })
} catch {
// Dialog didn't appear, which is fine - some operations might not require confirmation
return
}

// Fill the password field
await dialog.locator('input[type="password"]').fill(password)

// Click the confirm button
await dialog.getByRole('button', { name: 'Confirm' }).click()

// Wait for the dialog to disappear
await dialog.waitFor({ state: 'hidden' })

Check failure on line 32 in tests/playwright/support/utils/password-confirmation.ts

View workflow job for this annotation

GitHub Actions / Playwright tests 1 / 6

[admin-settings] › tests/playwright/e2e/appstore/admin-settings-apps.spec.ts:159:2 › Settings: App management › Limit app usage to group 

  1) [admin-settings] › tests/playwright/e2e/appstore/admin-settings-apps.spec.ts:159:2 › Settings: App management › Limit app usage to group 
    Error: locator.waitFor: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('.modal-container:has-text("Authentication required")') to be hidden
        50 × locator resolved to visible <div data-v-3c357e2d="" class="modal-container" id="modal-description-nc-vue-45">…</div>


       at ../support/utils/password-confirmation.ts:32

      30 |
      31 | 	// Wait for the dialog to disappear
    > 32 | 	await dialog.waitFor({ state: 'hidden' })
         | 	             ^
      33 | }
      34 |
        at handlePasswordConfirmation (/home/runner/actions-runner/_work/server/server/tests/playwright/support/utils/password-confirmation.ts:32:15)
        at /home/runner/actions-runner/_work/server/server/tests/playwright/e2e/appstore/admin-settings-apps.spec.ts:205:3

Check failure on line 32 in tests/playwright/support/utils/password-confirmation.ts

View workflow job for this annotation

GitHub Actions / merge-reports

[admin-settings] › tests/playwright/tests/playwright/e2e/appstore/admin-settings-apps.spec.ts:159:2 › Settings: App management › Limit app usage to group 

  1) [admin-settings] › tests/playwright/tests/playwright/e2e/appstore/admin-settings-apps.spec.ts:159:2 › Settings: App management › Limit app usage to group 
    Error: locator.waitFor: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('.modal-container:has-text("Authentication required")') to be hidden
        50 × locator resolved to visible <div data-v-3c357e2d="" class="modal-container" id="modal-description-nc-vue-45">…</div>


       at ../support/utils/password-confirmation.ts:32

      30 |
      31 | 	// Wait for the dialog to disappear
    > 32 | 	await dialog.waitFor({ state: 'hidden' })
         | 	             ^
      33 | }
      34 |
        at handlePasswordConfirmation (/home/runner/actions-runner/_work/server/server/tests/playwright/support/utils/password-confirmation.ts:32:15)
        at /home/runner/actions-runner/_work/server/server/tests/playwright/e2e/appstore/admin-settings-apps.spec.ts:205:3
}
Loading