feat(core): keyboard navigation and focus shortcut for unified search#62157
Merged
Conversation
pringelmann
added
accessibility
feature: search
team: IDP
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
July 15, 2026 09:19
2c9d44c to
a1ff563
Compare
pringelmann
marked this pull request as ready for review
July 15, 2026 10:10
pringelmann
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
July 15, 2026 10:10
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
July 15, 2026 10:28
a1ff563 to
decf927
Compare
pringelmann
marked this pull request as draft
July 15, 2026 13:10
Contributor
Author
|
Works in Orca, had to restart browser. Also tested NVDA on Windows. |
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
2 times, most recently
from
July 16, 2026 08:12
e20fdcc to
bcc4dc0
Compare
pringelmann
marked this pull request as ready for review
July 16, 2026 08:12
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
4 times, most recently
from
July 17, 2026 07:42
375aebd to
fa8cf00
Compare
kra-mo
approved these changes
Jul 17, 2026
kra-mo
left a comment
kra-mo
left a comment
Member
There was a problem hiding this comment.
I tested it out, really really nice :)
The UI for the selection highlight I'm guessing is out of scope for this, but will be changed, right?
(Switching apps like this is great!)
Contributor
Author
Yes, there is a separate sub-task for reworking the UI. This is mostly just for a11y |
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
2 times, most recently
from
July 17, 2026 10:08
494075a to
c3b24c4
Compare
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
feat/search-keyboard-nav
branch
from
July 17, 2026 10:36
c3b24c4 to
64ef6f5
Compare
susnux
reviewed
Jul 17, 2026
susnux
reviewed
Jul 17, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, could you add e2e tests (playwright) for this feature?
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
July 17, 2026 11:19
64ef6f5 to
5f5a62e
Compare
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
July 17, 2026 11:26
5f5a62e to
86537bf
Compare
susnux
approved these changes
Jul 17, 2026
Contributor
Author
|
/compile amend |
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
feat/search-keyboard-nav
branch
from
July 17, 2026 12:10
1c433f8 to
55a94d3
Compare
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Very cool @pringelmann! :) Makes search a lot more reachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the combobox keyboard model and a global focus shortcut to the new unified search.
Header input is a
combobox: up/down arrows move a highlighted result viaaria-activedescendant(focus stays in the input), Enter opens it, first result is auto-selected, and anaria-liveregion announces searching/result counts.Also added global focus shortcut ⌘/Ctrl+K.
Before:
After:
Not included
aria-selectedand dropping the result tab-stops need a small@nextcloud/vue(NcListItem) change, tracked as a follow-up for this subtask.Checklist
enhancement,3. to review, unified-search)AI (if applicable)