Skip to content

fix: make unified filter chip accessible#62265

Open
kristian-zendato wants to merge 1 commit into
masterfrom
fix/unified-search-chip-accessibility
Open

fix: make unified filter chip accessible#62265
kristian-zendato wants to merge 1 commit into
masterfrom
fix/unified-search-chip-accessibility

Conversation

@kristian-zendato

Copy link
Copy Markdown

Summary

The remove control on unified search filter chips was a plain <span> with a click handler: it was not keyboard-focusable and had no accessible name, so screen reader and keyboard users could not remove an active filter.
This changes the control to a real <button> and adds a translated aria-label ("Remove filter: {text}") so assistive technology announces which filter will be removed. Styles were adjusted so the button keeps the previous visual appearance

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kristian-zendato
kristian-zendato requested a review from a team as a code owner July 17, 2026 06:50
@kristian-zendato
kristian-zendato requested review from nfebe, skjnldsv and sorbaugh and removed request for a team July 17, 2026 06:50
Comment thread core/src/components/UnifiedSearch/SearchFilterChip.vue Outdated
</span>
<span class="text">{{ text }}</span>
<span class="close-icon" @click="deleteChip">
<button

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to prefer using our own components. If this is a chip, you can use the NcChip component ?
https://nextcloud-vue-components.netlify.app/#/Components/NcChip maybe ?

It already provides a close icon

@kristian-zendato
kristian-zendato force-pushed the fix/unified-search-chip-accessibility branch from 78cc5e9 to 8041ea3 Compare July 17, 2026 11:12
@kristian-zendato

Copy link
Copy Markdown
Author

@skjnldsv Thank you for your comments.
I updated the code to use NcChip as you recommended.
I'd appreciate it if you check it again.

@sorbaugh
sorbaugh requested a review from skjnldsv July 17, 2026 13:01

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but not tested

@susnux

susnux commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Ideally you could add a playwright test for this issue :)

@kristian-zendato
kristian-zendato force-pushed the fix/unified-search-chip-accessibility branch from 8041ea3 to 4e68a0c Compare July 20, 2026 09:08
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
@kristian-zendato
kristian-zendato force-pushed the fix/unified-search-chip-accessibility branch from 4e68a0c to 9fca0da Compare July 20, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] unified search chips are not in tab sequence

3 participants