fix: make unified filter chip accessible#62265
Open
kristian-zendato wants to merge 1 commit into
Open
Conversation
kristian-zendato
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
July 17, 2026 06:50
skjnldsv
reviewed
Jul 17, 2026
skjnldsv
reviewed
Jul 17, 2026
| </span> | ||
| <span class="text">{{ text }}</span> | ||
| <span class="close-icon" @click="deleteChip"> | ||
| <button |
Member
There was a problem hiding this comment.
We tend to prefer using our own components. If this is a chip, you can use the NcChip component ?
https://nextcloud-vue-components.netlify.app/#/Components/NcChip maybe ?
It already provides a close icon
kristian-zendato
force-pushed
the
fix/unified-search-chip-accessibility
branch
from
July 17, 2026 11:12
78cc5e9 to
8041ea3
Compare
Author
|
@skjnldsv Thank you for your comments. |
susnux
approved these changes
Jul 17, 2026
susnux
left a comment
Contributor
There was a problem hiding this comment.
code looks good but not tested
Contributor
|
Ideally you could add a playwright test for this issue :) |
kristian-zendato
force-pushed
the
fix/unified-search-chip-accessibility
branch
from
July 20, 2026 09:08
8041ea3 to
4e68a0c
Compare
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
kristian-zendato
force-pushed
the
fix/unified-search-chip-accessibility
branch
from
July 20, 2026 09:20
4e68a0c to
9fca0da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remove control on unified search filter chips was a plain
<span>with a click handler: it was not keyboard-focusable and had no accessible name, so screen reader and keyboard users could not remove an active filter.This changes the control to a real
<button>and adds a translatedaria-label("Remove filter: {text}") so assistive technology announces which filter will be removed. Styles were adjusted so the button keeps the previous visual appearanceChecklist
3. to review, feature component)stable32)AI (if applicable)