fixup! fix: get actual number of active users

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Author: kesselb

tests/lib/SessionStatisticsTest.php

@@ -27,6 +27,7 @@ class SessionStatisticsTest extends TestCase {
 	private ITimeFactory&MockObject $timeFactory;
 	private IDBConnection $connection;
 	private SessionStatistics $instance;
+	private int $currentTime;
 	private const TABLE = 'preferences';
 	private const OFFSET_5MIN = 300;
 	private const OFFSET_1HOUR = 3600;
@@ -35,7 +36,6 @@ class SessionStatisticsTest extends TestCase {
 	private const OFFSET_3MONTHS = 7776000;
 	private const OFFSET_6MONTHS = 15552000;
 	private const OFFSET_1YEAR = 31536000;
-	private const CURRENT_TIME = 100000000;
 
 
 	protected function setUp(): void {
@@ -47,6 +47,10 @@ protected function setUp(): void {
 
 		$this->instance = new SessionStatistics($this->connection, $this->timeFactory);
 
+		// when running the tests locally, you may have other lastLogin values in the database.
+		// using a timestamp in the future to workaround.
+		$this->currentTime = time() + (400 * 24 * 60 * 60);
+
 		$this->removeDummyValues();
 		$this->addDummyValues();
 	}
@@ -65,18 +69,18 @@ protected function removeDummyValues(): void {
 	}
 
 	private function addDummyValues(): void {
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_5MIN + 1, 10);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_5MIN + 1, 11);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1HOUR + 1, 20);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1HOUR + 1, 21);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1HOUR + 1, 22);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1DAY + 1, 30);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1MONTH + 1, 50);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_3MONTHS + 1, 60);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_6MONTHS + 1, 70);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1YEAR + 1, 80);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1YEAR + 1, 81);
-		$this->addDummyValuesWithLastLogin(self::CURRENT_TIME - self::OFFSET_1YEAR + 1, 82);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_5MIN + 1, 10);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_5MIN + 1, 11);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1HOUR + 1, 20);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1HOUR + 1, 21);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1HOUR + 1, 22);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1DAY + 1, 30);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1MONTH + 1, 50);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_3MONTHS + 1, 60);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_6MONTHS + 1, 70);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1YEAR + 1, 80);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1YEAR + 1, 81);
+		$this->addDummyValuesWithLastLogin($this->currentTime - self::OFFSET_1YEAR + 1, 82);
 	}
 
 	private function addDummyValuesWithLastLogin($lastActivity, $id): void {
@@ -98,7 +102,7 @@ private function addDummyValuesWithLastLogin($lastActivity, $id): void {
 
 	public function testGetSessionStatistics() {
 		$this->timeFactory->expects($this->any())->method('getTime')
-			->willReturn(self::CURRENT_TIME);
+			->willReturn($this->currentTime);
 
 		$result = $this->instance->getSessionStatistics();