👌 IMPROVE: composer#996
Draft
violoncelloCH wants to merge 1 commit into
Draft
Conversation
- button in appnavigation to create post -> open modal - composer in timeline not sticky - reply opens composer in modal - use vuex to store composer reply and modal open state Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
681f263 to
b3574eb
Compare
Member
Member
Author
|
thanks @jancborchardt for the feedback some further points we should probably do in this PR as they touch the composer quite fundamentally:
|
Member
Author
|
Hi, |
Member
|
@ArtificialOwl let’s not close longstanding pull requests without comment – reopening. :) |
jancborchardt
requested changes
Sep 4, 2025
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Still a very nice improvement and my review from above still stands. FYI @ArtificialOwl
Nice with the posting modal from anywhere! 2 issues:
- Attachments don’t show (note they show in the main composer in the background)
- The visibility dropdown is cut off by the edge of the modal on the bottom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TODO: