Skip to content

👌 IMPROVE: composer#996

Draft
violoncelloCH wants to merge 1 commit into
masterfrom
imp/composer-improvements
Draft

👌 IMPROVE: composer#996
violoncelloCH wants to merge 1 commit into
masterfrom
imp/composer-improvements

Conversation

@violoncelloCH

Copy link
Copy Markdown
Member
  • button in appnavigation to create post -> open modal
  • composer in timeline not sticky
  • reply opens composer in modal
  • use vuex to store composer reply and modal open state

TODO:

  • store complete composer state in vuex so it doesn't get lost when composer modal is closed (accidentally)
  • Visibility button should have text next to it:
    • "Visible publicly", "Unlisted", "Visible to followers"
    • Post button could only say "Post"
    • "Direct message" should not show here
  • composer input placeholder should be shown if composer is empty again
  • allow to post image without text
  • immediate feedback about sent post

- button in appnavigation to create post -> open modal
- composer in timeline not sticky
- reply opens composer in modal
- use vuex to store composer reply and modal open state

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@icewind1991 icewind1991 force-pushed the imp/composer-improvements branch from 681f263 to b3574eb Compare October 12, 2020 15:53
@jancborchardt

Copy link
Copy Markdown
Member

Nice with the posting modal from anywhere! 2 issues:

  • Attachments don’t show (note they show in the main composer in the background)
  • The visibility dropdown is cut off by the edge of the modal on the bottom

image

@violoncelloCH

violoncelloCH commented Oct 18, 2020

Copy link
Copy Markdown
Member Author

thanks @jancborchardt for the feedback
sadly I currently don't have time to continue working on this... so @icewind1991 (or anyone else) if you want to continue on this one feel free...

some further points we should probably do in this PR as they touch the composer quite fundamentally:

@violoncelloCH

Copy link
Copy Markdown
Member Author

Hi,
Same as in #744: even though this isn't finished I think there is still some notable improvements in here which would be worth a rebase...

@jancborchardt

Copy link
Copy Markdown
Member

@ArtificialOwl let’s not close longstanding pull requests without comment – reopening. :)

@jancborchardt jancborchardt reopened this May 16, 2023

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a very nice improvement and my review from above still stands. FYI @ArtificialOwl

Nice with the posting modal from anywhere! 2 issues:

  • Attachments don’t show (note they show in the main composer in the background)
  • The visibility dropdown is cut off by the edge of the modal on the bottom

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants