fix(recording): Reduce config key length for request-upload configs

Signed-off-by: Joas Schilling <coding@schilljs.com>

Author: nickvergessen

lib/Service/RecordingService.php

@@ -54,7 +54,7 @@ class RecordingService {
 	public const CONSENT_REQUIRED_OPTIONAL = 2;
 
 	public const APPCONFIG_PREFIX = 'recording/';
-	public const APPCONFIG_UPLOAD_PREFIX = 'recording-upload/';
+	public const APPCONFIG_UPLOAD_PREFIX = 'recupload/';
 
 	public const DEFAULT_ALLOWED_RECORDING_FORMATS = [
 		'audio/ogg' => ['ogg'],
@@ -315,7 +315,7 @@ private function cleanupUploadShare(Room $room, string $fileName): void {
 	}
 
 	private function getUploadShareConfigKey(Room $room, string $fileName): string {
-		return self::APPCONFIG_UPLOAD_PREFIX . $room->getToken() . '/' . basename($fileName);
+		return self::APPCONFIG_UPLOAD_PREFIX . $room->getToken() . '/' . sha1(basename($fileName));
 	}
 
 	/**

tests/php/Service/RecordingServiceTest.php

@@ -246,7 +246,7 @@ public function testRequestUpload(): void {
 
 		$this->appConfig->expects($this->once())
 			->method('setAppValueString')
-			->with(RecordingService::APPCONFIG_UPLOAD_PREFIX . 'token123/recording.mp4', 'shareToken', true, true);
+			->with(RecordingService::APPCONFIG_UPLOAD_PREFIX . 'token123/' . sha1('recording.mp4'), 'shareToken', true, true);
 
 		// The active-recording marker is cleared once the upload share is created,
 		// so a new recording can start while this one is still being uploaded.
@@ -324,7 +324,7 @@ public function testFinishUpload(): void {
 		// Only the temporary upload share's tracking value is cleared here; the
 		// active-recording marker was already removed in requestUpload().
 		$this->appConfig->expects($this->once())->method('deleteAppValue')
-			->with(RecordingService::APPCONFIG_UPLOAD_PREFIX . 'token123/name.ogg');
+			->with(RecordingService::APPCONFIG_UPLOAD_PREFIX . 'token123/' . sha1('name.ogg'));
 
 		$this->notificationManager->expects($this->once())->method('notify');