Skip to content

fix: align buttons in the navigation#17789

Merged
ShGKme merged 4 commits intomainfrom
fix/left-sidebar-alignment
May 1, 2026
Merged

fix: align buttons in the navigation#17789
ShGKme merged 4 commits intomainfrom
fix/left-sidebar-alignment

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Apr 23, 2026

☑️ Resolves

  • Fix Sidebar "Settings" and "Archived" buttons misaligned with other apps #16320
  • Fix 'Talk settings' button appearance #13924
  • 👁️👃👁️ Review without whitespaces by commits
  • Alignment:
    • Icons aligned by width and icons' centers
    • Text aligned by the position on the left
    • Adapts to the compact mode
  • Counter/badge style mention on Archived conversations
  • Paddings:
    • 2x padding on entire navigation perimeter
    • 2x padding between search block and buttons
    • 1x padding between items, including visual padding between top buttons and the list, the list and the bottom block
  • Chips aligned with the search and moved closer

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

ShGKme added 4 commits April 23, 2026 19:51
Extract from further changes for simpler review

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Prevent extra gap when there are no chips

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Also use real buttons as button instead of invalid list items and links

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the 🏖️ Next Major (34) milestone Apr 23, 2026
@ShGKme ShGKme requested review from Antreesy and nimishavijay April 23, 2026 18:09
@ShGKme ShGKme self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually good

@ShGKme
Copy link
Copy Markdown
Contributor Author

ShGKme commented Apr 24, 2026

Notes:

  • NcListItem doesn't fit well: doesn't support buttons well and still requires dirty overrides
  • NcAppNavigationItem - even more limited

NcButton also needed hacks.

I don't see any good solution here without components rethinking.

Copy link
Copy Markdown
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise also good 👌🏽
it's 34 only?

@ShGKme
Copy link
Copy Markdown
Contributor Author

ShGKme commented Apr 24, 2026

it's 34 only?

I think so

@ShGKme
Copy link
Copy Markdown
Contributor Author

ShGKme commented Apr 27, 2026

Might need rework with the new design:

@ShGKme ShGKme merged commit 68eee1a into main May 1, 2026
53 checks passed
@ShGKme ShGKme deleted the fix/left-sidebar-alignment branch May 1, 2026 07:19
@ShGKme
Copy link
Copy Markdown
Contributor Author

ShGKme commented May 1, 2026

Might need rework with the new design

Will need, but it only results in the old design for active Home button and the required change is a significant amount if work or library changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar "Settings" and "Archived" buttons misaligned with other apps 'Talk settings' button appearance

4 participants