feat: Add last-common-read to chat relay#18433
Merged
nickvergessen merged 2 commits intoJun 29, 2026
Merged
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
added
enhancement
feature: chat 💬
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
feat/noid/add-last-common-read-to-chat-relay
branch
from
35badc6 to
5ba63c3
Compare
4 tasks
nickvergessen
approved these changes
Jun 29, 2026
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Codewise fine
Frontend should also adapt this field, cc @Antreesy
Member
|
Psalm is unrelated |
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
This was referenced Jun 29, 2026
11 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
When using chat relay, we are not updating the readmarker (that is the received lastCommonRead, we do update our own readmarker). So the only way to do it while staying in a conversation is to wait for the next api request, which will include that.
We cannot add a property on the level of
comment, the signaling controller does not allow that (since it also allows sending multiple chat messages in one signaling messages).Downsides here are:
🏁 Checklist
docs/has been updated or is not required