Skip to content

Commit 5e0e8bc

Browse files
committed
unit fail
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
1 parent 353cde4 commit 5e0e8bc

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

tests/unit/Service/LegacyRowMapperTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,8 @@ public function testMigrateLegacyRow() {
137137
$data2 = $row2->getData();
138138

139139
self::assertTrue($data === $data2);
140-
self::assertTrue($legacyRow->jsonSerialize() === $row2->jsonSerialize());
140+
$row2Serialized = $row2->jsonSerialize();
141+
unset($row2Serialized['dataByAlias']);
142+
self::assertTrue($legacyRow->jsonSerialize() === $row2Serialized);
141143
}
142144
}

tests/unit/Validation/ColumnDtoValidatorTest.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ public function testTechnicalNameOver200CharsIsRejected(): void {
5454
$this->validator->validate($this->dto('test' . str_repeat('t', 197)));
5555
}
5656

57+
/**
58+
* @dataProvider reservedNameProvider
59+
*/
5760
#[DataProvider('reservedNameProvider')]
5861
public function testReservedTechnicalNamesAreRejected(string $name): void {
5962
$this->expectException(BadRequestError::class);
@@ -72,6 +75,9 @@ public static function reservedNameProvider(): array {
7275
];
7376
}
7477

78+
/**
79+
* @dataProvider invalidFormatProvider
80+
*/
7581
#[DataProvider('invalidFormatProvider')]
7682
public function testInvalidFormatIsRejected(string $name): void {
7783
$this->expectException(BadRequestError::class);
@@ -90,6 +96,9 @@ public static function invalidFormatProvider(): array {
9096
];
9197
}
9298

99+
/**
100+
* @dataProvider validFormatProvider
101+
*/
93102
#[DataProvider('validFormatProvider')]
94103
public function testValidFormatIsAccepted(string $name): void {
95104
$this->expectNotToPerformAssertions();

0 commit comments

Comments
 (0)