Fix: Large table causes sql error

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>

Author: Koc

lib/Db/Row2Mapper.php

@@ -28,7 +28,7 @@
 use Throwable;
 
 class Row2Mapper {
-	private const ROWS_LOADING_CHUNK_SIZE = 5000;
+	private const MAX_DB_PARAMETERS = 65535;
 
 	use TTransactional;
 
@@ -195,16 +195,37 @@ public function findAll(array $showColumnIds, int $tableId, ?int $limit = null,
 	 * @throws InternalError
 	 */
 	private function getRows(array $rowIds, array $columnIds): array {
-		if (count($rowIds) > self::ROWS_LOADING_CHUNK_SIZE) {
-			$chunks = [];
-			do {
-				$chunkRowIds = array_splice($rowIds, 0, self::ROWS_LOADING_CHUNK_SIZE);
-				$chunks[] = $this->getRows($chunkRowIds, $columnIds);
-			} while (count($rowIds) > self::ROWS_LOADING_CHUNK_SIZE);
+		if (empty($rowIds)) {
+			return [];
+		}
+
+		$columnTypesCount = count($this->columnsHelper->columns);
+		if ($columnTypesCount === 0) {
+			return [];
+		}
 
-			return array_merge(...$chunks);
+		$columnsCount = count($columnIds);
+		$maxParamsPerType = floor(self::MAX_DB_PARAMETERS / $columnTypesCount) ;
+		$calculatedChunkSize = (int)($maxParamsPerType - $columnsCount);
+		$chunkSize = max(1, $calculatedChunkSize);
+
+		$rowIdChunks = array_chunk($rowIds, $chunkSize);
+		$chunks = [];
+		foreach ($rowIdChunks as $chunkedRowIds) {
+			$chunks[] = $this->getRowsChunk($chunkedRowIds, $columnIds);
 		}
 
+		return array_merge(...$chunks);
+	}
+
+	/**
+	 * Builds and executes the UNION ALL query for a specific chunk of rows.
+	 * @param array $rowIds
+	 * @param array $columnIds
+	 * @return Row2[]
+	 * @throws InternalError
+	 */
+	private function getRowsChunk(array $rowIds, array $columnIds): array {
 		$qb = $this->db->getQueryBuilder();
 
 		$qbSqlForColumnTypes = null;