Perf: Optimize shares loading by eliminating N+1 queries (code review fixes)

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>

Author: Koc

lib/Db/ShareMapper.php

@@ -100,14 +100,25 @@ public function findShareForNode(int $nodeId, string $nodeType, string $receiver
 	 * @throws Exception
 	 */
 	public function findAllSharesFor(string $nodeType, array $receivers, string $userId, ?string $receiverType = 'user'): array {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from($this->table)
-			->where($qb->expr()->in('receiver', $qb->createNamedParameter($receivers, IQueryBuilder::PARAM_STR_ARRAY)))
-			->andWhere($qb->expr()->neq('sender', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR)))
-			->andWhere($qb->expr()->eq('node_type', $qb->createNamedParameter($nodeType, IQueryBuilder::PARAM_STR)))
-			->andWhere($qb->expr()->eq('receiver_type', $qb->createNamedParameter($receiverType, IQueryBuilder::PARAM_STR)));
-		return $this->findEntities($qb);
+		if (!$receivers) {
+			return [];
+		}
+
+		$chunks = [];
+		// deduct extra parameters (sender, node type, receiver type)
+		foreach (array_chunk($receivers, 1000 - 3) as $receiversChunk) {
+			$qb = $this->db->getQueryBuilder();
+			$qb->select('*')
+				->from($this->table)
+				->where($qb->expr()->in('receiver', $qb->createNamedParameter($receiversChunk, IQueryBuilder::PARAM_STR_ARRAY)))
+				->andWhere($qb->expr()->neq('sender', $qb->createNamedParameter($userId)))
+				->andWhere($qb->expr()->eq('node_type', $qb->createNamedParameter($nodeType)))
+				->andWhere($qb->expr()->eq('receiver_type', $qb->createNamedParameter($receiverType)));
+
+			$chunks[] = $this->findEntities($qb);
+		}
+
+		return array_merge(...$chunks);
 	}
 
 	/**

lib/Db/TableMapper.php

@@ -70,16 +70,18 @@ public function findMany(array $ids): array {
 			return $result;
 		}
 
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from($this->table)
-			->where($qb->expr()->in('id', $qb->createNamedParameter(array_keys($missing), IQueryBuilder::PARAM_INT_ARRAY)));
+		$missing = array_keys($missing);
+		foreach (array_chunk($missing, 1000) as $missingChunk) {
+			$qb = $this->db->getQueryBuilder();
+			$qb->select('*')
+				->from($this->table)
+				->where($qb->expr()->in('id', $qb->createNamedParameter($missingChunk, IQueryBuilder::PARAM_INT_ARRAY)));
 
-		$entities = $this->findEntities($qb);
-		foreach ($entities as $entity) {
-			$id = $entity->getId();
-			$this->cache[(string)$id] = $entity;
-			$result[$id] = $entity;
+			foreach ($this->findEntities($qb) as $entity) {
+				$id = $entity->getId();
+				$this->cache[(string)$id] = $entity;
+				$result[$id] = $entity;
+			}
 		}
 		return $result;
 	}

lib/Db/ViewMapper.php

@@ -70,17 +70,19 @@ public function findMany(array $ids): array {
 			return $result;
 		}
 
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('v.*', 't.ownership')
-			->from($this->table, 'v')
-			->innerJoin('v', 'tables_tables', 't', 't.id = v.table_id')
-			->where($qb->expr()->in('v.id', $qb->createNamedParameter(array_keys($missing), IQueryBuilder::PARAM_INT_ARRAY)));
-
-		$entities = $this->findEntities($qb);
-		foreach ($entities as $entity) {
-			$id = $entity->getId();
-			$this->cache[(string)$id] = $entity;
-			$result[$id] = $entity;
+		$missing = array_keys($missing);
+		foreach (array_chunk($missing, 1000) as $missingChunk) {
+			$qb = $this->db->getQueryBuilder();
+			$qb->select('v.*', 't.ownership')
+				->from($this->table, 'v')
+				->innerJoin('v', 'tables_tables', 't', 't.id = v.table_id')
+				->where($qb->expr()->in('v.id', $qb->createNamedParameter($missingChunk, IQueryBuilder::PARAM_INT_ARRAY)));
+
+			foreach ($this->findEntities($qb) as $entity) {
+				$id = $entity->getId();
+				$this->cache[(string)$id] = $entity;
+				$result[$id] = $entity;
+			}
 		}
 		return $result;
 	}

lib/Helper/CircleHelper.php

@@ -11,7 +11,6 @@
 use OCA\Circles\Model\Circle;
 use OCA\Circles\Model\Member;
 use OCA\Circles\Model\Probes\CircleProbe;
-use OCA\Tables\Errors\InternalError;
 use OCP\App\IAppManager;
 use OCP\IL10N;
 use OCP\Server;
@@ -77,7 +76,6 @@ public function getCircleDisplayName(string $circleId, string $userId): string {
 	/**
 	 * @param string $userId
 	 * @return Circle[]
-	 * @throws InternalError
 	 */
 	public function getUserCircles(string $userId): array {
 		if (!$this->circlesEnabled) {