style(convo-list): mark convos as read/unread optimistically but reset+show error snackbar on failure

AI-assistant: Claude Code v2.1.140 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt

@@ -462,9 +462,6 @@ class ConversationsListActivity : BaseActivity() {
             conversationsListViewModel.readUnreadState.collect { state ->
                 when (state) {
                     is ConversationsListViewModel.ConversationReadUnreadUiState.Success -> {
-                        fetchRooms()
-                        val resId = if (state.isMarkedRead) R.string.marked_as_read else R.string.marked_as_unread
-                        showSnackbar(String.format(resources.getString(resId), state.conversationDisplayName))
                         conversationsListViewModel.resetReadUnreadState()
                     }
                     is ConversationsListViewModel.ConversationReadUnreadUiState.Error -> {

app/src/main/java/com/nextcloud/talk/conversationlist/data/OfflineConversationsRepository.kt

@@ -44,6 +44,8 @@ interface OfflineConversationsRepository {
 
     suspend fun updateConversation(conversationModel: ConversationModel)
 
+    suspend fun updateConversationLocallyAndEmit(user: User, conversation: ConversationModel)
+
     @Deprecated("use observeConversation")
     suspend fun getLocallyStoredConversation(user: User, roomToken: String): ConversationModel?
 

app/src/main/java/com/nextcloud/talk/conversationlist/data/network/OfflineFirstConversationsRepository.kt

@@ -127,6 +127,12 @@ class OfflineFirstConversationsRepository @Inject constructor(
         dao.updateConversation(entity)
     }
 
+    override suspend fun updateConversationLocallyAndEmit(user: User, conversation: ConversationModel) {
+        dao.updateConversation(conversation.asEntity())
+        val updatedList = getListOfConversations(user.id!!)
+        _roomListFlow.emit(updatedList)
+    }
+
     override suspend fun getLocallyStoredConversation(user: User, roomToken: String): ConversationModel? {
         val id = user.id!!
         return getConversation(id, roomToken)

app/src/main/java/com/nextcloud/talk/conversationlist/viewmodels/ConversationsListViewModel.kt

@@ -108,8 +108,7 @@ class ConversationsListViewModel @Inject constructor(
 
     sealed class ConversationReadUnreadUiState {
         data object None : ConversationReadUnreadUiState()
-        data class Success(val conversationDisplayName: String, val isMarkedRead: Boolean) :
-            ConversationReadUnreadUiState()
+        data object Success : ConversationReadUnreadUiState()
         data object Error : ConversationReadUnreadUiState()
     }
 
@@ -582,38 +581,54 @@ class ConversationsListViewModel @Inject constructor(
 
     @Suppress("Detekt.TooGenericExceptionCaught")
     fun markConversationAsRead(conversation: ConversationModel) {
+        val original = conversation.copy()
+        val optimistic = conversation.copy(unreadMessages = 0, unreadMention = false, unreadMentionDirect = false)
         val messageId = if (conversation.remoteServer.isNullOrEmpty()) conversation.lastMessage?.id?.toInt() else null
         val apiVersion = ApiUtils.getChatApiVersion(
             currentUser.capabilities?.spreedCapability!!,
             intArrayOf(ApiUtils.API_V1)
         )
         val url = ApiUtils.getUrlForChatReadMarker(apiVersion, currentUser.baseUrl, conversation.token)
         viewModelScope.launch {
+            withContext(Dispatchers.IO) {
+                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+            }
             try {
                 withContext(Dispatchers.IO) {
                     withRetry(1) { conversationsRepository.markConversationAsRead(credentials, url, messageId) }
                 }
-                _readUnreadState.value = ConversationReadUnreadUiState.Success(conversation.displayName, true)
+                _readUnreadState.value = ConversationReadUnreadUiState.Success
             } catch (e: Exception) {
+                withContext(Dispatchers.IO) {
+                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                }
                 _readUnreadState.value = ConversationReadUnreadUiState.Error
             }
         }
     }
 
     @Suppress("Detekt.TooGenericExceptionCaught")
     fun markConversationAsUnread(conversation: ConversationModel) {
+        val original = conversation.copy()
+        val optimistic = conversation.copy(unreadMessages = 1)
         val apiVersion = ApiUtils.getChatApiVersion(
             currentUser.capabilities?.spreedCapability!!,
             intArrayOf(ApiUtils.API_V1)
         )
         val url = ApiUtils.getUrlForChatReadMarker(apiVersion, currentUser.baseUrl, conversation.token)
         viewModelScope.launch {
+            withContext(Dispatchers.IO) {
+                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+            }
             try {
                 withContext(Dispatchers.IO) {
                     withRetry(1) { conversationsRepository.markConversationAsUnread(credentials, url) }
                 }
-                _readUnreadState.value = ConversationReadUnreadUiState.Success(conversation.displayName, false)
+                _readUnreadState.value = ConversationReadUnreadUiState.Success
             } catch (e: Exception) {
+                withContext(Dispatchers.IO) {
+                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                }
                 _readUnreadState.value = ConversationReadUnreadUiState.Error
             }
         }