Skip to content

Commit bf9f374

Browse files
committed
Updated shouldAutoplayGif to not have more than 2 return statements.
Removed unused import statements Signed-off-by: Jens Zalzala <jens@shakingearthdigital.com>
1 parent 092c87e commit bf9f374

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

app/src/main/java/com/nextcloud/talk/adapters/messages/PreviewMessageViewHolder.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import android.os.Handler
1717
import android.util.Base64
1818
import android.util.Log
1919
import android.view.View
20-
import android.view.ViewGroup
2120
import android.widget.ImageView
2221
import android.widget.ProgressBar
2322
import android.widget.TextView
@@ -50,7 +49,6 @@ import com.nextcloud.talk.utils.message.MessageUtils
5049
import com.stfalcon.chatkit.messages.MessageHolders.IncomingImageMessageViewHolder
5150
import coil.load
5251
import com.nextcloud.talk.utils.ApiUtils
53-
import com.nextcloud.talk.utils.MimetypeUtils
5452
import io.reactivex.Single
5553
import io.reactivex.SingleObserver
5654
import io.reactivex.disposables.Disposable
@@ -109,7 +107,6 @@ abstract class PreviewMessageViewHolder(itemView: View?, payload: Any?) :
109107
messageText.visibility = View.VISIBLE
110108

111109
// Check if image is GIF and load animated image
112-
val mimetype = message.selectedIndividualHashMap?.get(KEY_MIMETYPE)
113110
if (message.imageUrl != null && message.shouldAutoplayGif()) {
114111
image.adjustViewBounds = true
115112
image.load(message.imageUrl) {

app/src/main/java/com/nextcloud/talk/chat/data/model/ChatMessage.kt

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -242,12 +242,15 @@ data class ChatMessage(
242242
*/
243243
fun shouldAutoplayGif(): Boolean {
244244
val mimetype = selectedIndividualHashMap?.get("mimetype")
245-
if (mimetype != Mimetype.IMAGE_GIF) return false
246-
val user = activeUser ?: return false
247-
val capabilities = user.capabilities?.spreedCapability ?: return false
248-
val maxGifSize = CapabilitiesUtil.getMaxGifSize(capabilities)
249-
val fileSize = selectedIndividualHashMap?.get("size")?.toLongOrNull() ?: return true
250-
return fileSize in 1..maxGifSize
245+
val capabilities = activeUser?.capabilities?.spreedCapability
246+
val fileSize = selectedIndividualHashMap?.get("size")?.toLongOrNull()
247+
248+
return if (mimetype != Mimetype.IMAGE_GIF || activeUser == null || capabilities == null) {
249+
false
250+
} else {
251+
val maxGifSize = CapabilitiesUtil.getMaxGifSize(capabilities)
252+
fileSize == null || fileSize in 1..maxGifSize
253+
}
251254
}
252255

253256
@Suppress("Detekt.NestedBlockDepth")

app/src/main/java/com/nextcloud/talk/ui/ComposeChatAdapter.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ import com.nextcloud.talk.ui.theme.ViewThemeUtils
107107
import com.nextcloud.talk.users.UserManager
108108
import com.nextcloud.talk.utils.ApiUtils
109109
import com.nextcloud.talk.utils.DateUtils
110-
import com.nextcloud.talk.utils.Mimetype
111110
import com.nextcloud.talk.utils.DisplayUtils
112111
import com.nextcloud.talk.utils.DrawableUtils.getDrawableResourceIdForMimeType
113112
import com.nextcloud.talk.utils.message.MessageUtils

0 commit comments

Comments
 (0)