fix: Add logging in case of http error and add user agent to all requests

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

app/src/main/java/fr/dudie/nominatim/client/TalkJsonNominatimClient.java

@@ -153,13 +153,16 @@ public List<Address> search(final NominatimSearchRequest search) throws IOExcept
                 .build();
 
         Response response = httpClient.newCall(requesthttp).execute();
+        ResponseBody responseBody = response.body();
         if (response.isSuccessful()) {
-            ResponseBody responseBody = response.body();
             if (responseBody != null) {
                 return gson.fromJson(responseBody.string(), new TypeToken<List<Address>>() {
                 }.getType());
             }
         } else {
+            if (responseBody != null) {
+                Log.w(TAG, "search failed: " + response.code() + " " + responseBody);
+            }
             Log.w(TAG, "search failed with HTTP-code: " + response.code());
         }
 
@@ -178,16 +181,22 @@ public Address getAddress(final NominatimReverseRequest reverse) throws IOExcept
         Log.d(TAG, "reverse geocoding url: " + apiCall);
 
         Request requesthttp = new Request.Builder()
-                .addHeader("accept", "application/json")
-                .url(apiCall)
-                .build();
+            .addHeader("accept", "application/json")
+            .addHeader("User-Agent", ApiUtils.getUserAgent())
+            .url(apiCall)
+            .build();
 
         Response response = httpClient.newCall(requesthttp).execute();
+        ResponseBody responseBody = response.body();
         if (response.isSuccessful()) {
-            ResponseBody responseBody = response.body();
             if (responseBody != null) {
                 return gson.fromJson(responseBody.string(), Address.class);
             }
+        } else {
+            if (responseBody != null) {
+                Log.w(TAG, "get address failed: " + response.code() + " " + responseBody);
+            }
+            Log.w(TAG, "get address failed with HTTP-code: " + response.code());
         }
 
         return null;
@@ -203,18 +212,25 @@ public List<Address> lookupAddress(final NominatimLookupRequest lookup) throws I
 
         final String apiCall = String.format("%s&%s", lookupUrl, lookup.getQueryString());
         Log.d(TAG, "lookup url: " + apiCall);
+
         Request requesthttp = new Request.Builder()
                 .addHeader("accept", "application/json")
+                .addHeader("User-Agent", ApiUtils.getUserAgent())
                 .url(apiCall)
                 .build();
 
         Response response = httpClient.newCall(requesthttp).execute();
+        ResponseBody responseBody = response.body();
         if (response.isSuccessful()) {
-            ResponseBody responseBody = response.body();
             if (responseBody != null) {
                 return gson.fromJson(responseBody.string(), new TypeToken<List<Address>>() {
                 }.getType());
             }
+        } else {
+            if (responseBody != null) {
+                Log.w(TAG, "address lookup failed: " + response.code() + " " + responseBody);
+            }
+            Log.w(TAG, "address lookup failed with HTTP-code: " + response.code());
         }
 
         return new ArrayList<>();