Skip to content

Feature/3074/improve threads7#5388

Merged
mahibi merged 22 commits intomasterfrom
feature/3074/improveThreads7
Sep 18, 2025
Merged

Feature/3074/improve threads7#5388
mahibi merged 22 commits intomasterfrom
feature/3074/improveThreads7

Conversation

@mahibi
Copy link
Copy Markdown
Collaborator

@mahibi mahibi commented Sep 16, 2025

This PR enables the message search to handle threads.

As partly seen in the screenshots i fixed quite some things which are not related to threads. There is a lot more to do to improve the search result screen (context search) but more fixes to it are out of scope of this PR.

🖼️ Screenshots

Search result for "some random message" which was posted in a normal chat (no thread)

🏚️ Before 🏡 After
grafik grafik

Search result for "first message in very new thread" which was posted in a thread

🏚️ Before (just the same screen as without threads) 🏡 After (correct messages are shown + threadname as subtitle)
grafik grafik

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added this to the 23.0.0 milestone Sep 16, 2025
@mahibi mahibi self-assigned this Sep 16, 2025
@mahibi mahibi force-pushed the feature/3074/improveThreads7 branch 2 times, most recently from 533b0d5 to 9881d1e Compare September 18, 2025 13:47
@mahibi mahibi marked this pull request as ready for review September 18, 2025 13:47
@mahibi mahibi added the 3. to review Waiting for reviews label Sep 18, 2025
-> show only normal chat messages or only threads messages

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
without this fix, the time was squeezed to the right.

this change is not related to threads. just a drive by fix..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
still experimental. calculation takes too long, but everything is aligned correctly

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
time always shown under message

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
…sage

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
…h results

before, it also sorted out normal messages with replies

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/3074/improveThreads7 branch from 9881d1e to a2386cc Compare September 18, 2025 18:25
@mahibi mahibi enabled auto-merge September 18, 2025 18:25
@mahibi
Copy link
Copy Markdown
Collaborator Author

mahibi commented Sep 18, 2025

/backport to stable-22.0

@github-actions
Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code6262
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9090

@mahibi mahibi merged commit e475b88 into master Sep 18, 2025
16 checks passed
@mahibi mahibi deleted the feature/3074/improveThreads7 branch September 18, 2025 18:39
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5388.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message threads

2 participants