Merged
Conversation
although it's not a nice solution to pass around and modify the intent, i will stick with this to avoid too many changes before the 22.0.0 release Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
fix: when opened via notification, backpress will now open chat instead bluescreen from MainActivity modify: this will affect that backpress from thread after coming from threadlist will open the chat, which is not expected to be improved... Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
only when coming from notification and backpress is done in a thread, then open the conversationlist Introducing the extra openedViaNotification for this is not a nice solution. But for release of 22.0.0 greater changes should be avoided. Best might be for take care of the backstack completely by activities intent flags instead to override handleOnBackPressed Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Collaborator
Author
|
/backport to stable-22.0 |
Contributor
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5395.apk |
Ivansss
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR will add the possibility to open threads via notification
(while keeping the behavior that backpress in thread that was opened via the threads-list should open the list again)
While it's tempting to do refactoring in the touched code parts, i won't do it now to avoid too many changes regarding the release of 22.0.0
Just some thoughts for later:
is overriding handleOnBackPressed with own logic the best solution?
MainActivity might be removed in the future (redirecting could be done differently?, it only still exists as remnant from conductor architechture). This will also allow easier backstack handling (e.g. without the
openedViaNotificationsolution in this PR, the old codeended up in showing the MainActivity (which should never be displayed besides when redirecting).
NotificationWorker needs to be refactored. E.g. passing intents/bundles through the whole class is confusing...
🏁 Checklist
/backport to stable-xx.x