Skip to content

[stable-22.0] open threads via notification#5396

Merged
mahibi merged 3 commits intostable-22.0from
backport/5395/stable-22.0
Sep 19, 2025
Merged

[stable-22.0] open threads via notification#5396
mahibi merged 3 commits intostable-22.0from
backport/5395/stable-22.0

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Sep 19, 2025

Backport of PR #5395

although it's not a nice solution to pass around and modify the intent, i will stick with this to avoid too many changes before the 22.0.0 release

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
fix: when opened via notification, backpress will now open chat instead bluescreen from MainActivity

modify: this will affect that backpress from thread after coming from threadlist will open the chat, which is not expected

to be improved...

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
only when coming from notification and backpress is done in a thread, then open the conversationlist

Introducing the extra openedViaNotification for this is not a nice solution. But for release of 22.0.0 greater changes should be avoided.

Best might be for take care of the backstack completely by activities intent flags instead to override handleOnBackPressed

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@backportbot backportbot Bot requested review from Ivansss and mahibi September 19, 2025 11:56
@backportbot backportbot Bot added the 3. to review Waiting for reviews label Sep 19, 2025
@backportbot backportbot Bot added this to the 22.0.0 milestone Sep 19, 2025
@mahibi mahibi enabled auto-merge September 19, 2025 11:56
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5396.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code6262
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9090

@mahibi mahibi merged commit d5472ca into stable-22.0 Sep 19, 2025
14 checks passed
@mahibi mahibi deleted the backport/5395/stable-22.0 branch September 19, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant