Hide online-only settings in Settings screen when offline#5458
Merged
Conversation
sowjanyakch
changed the title
sowjanyakch
force-pushed
the
bugfix/5440/hideSettings
branch
from
b5f6adf to
78789a8
Compare
rapterjet2004
requested changes
Oct 15, 2025
rapterjet2004
left a comment
rapterjet2004
left a comment
Contributor
There was a problem hiding this comment.
Hide the proxy settings too, no use having them if the app is offline
sowjanyakch
force-pushed
the
bugfix/5440/hideSettings
branch
2 times, most recently
from
c7f96d3 to
103ee03
Compare
sowjanyakch
force-pushed
the
bugfix/5440/hideSettings
branch
2 times, most recently
from
9171f57 to
f142a0c
Compare
rapterjet2004
approved these changes
Oct 23, 2025
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
sowjanyakch
force-pushed
the
bugfix/5440/hideSettings
branch
from
f142a0c to
477208e
Compare
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5458.apk |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #5440
🚧 TODO
🏁 Checklist
/backport to stable-xx.x