Skip to content

⚒️🎨 Migrate to MapLibre#5962

Merged
AndyScherzinger merged 15 commits intomasterfrom
feat/noid/migrateToMapLibre
Mar 18, 2026
Merged

⚒️🎨 Migrate to MapLibre#5962
AndyScherzinger merged 15 commits intomasterfrom
feat/noid/migrateToMapLibre

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Mar 12, 2026 •
edited
Loading

  • replace OSMdroid with MapLibre and re-implement/preserve the features (current location, zoom, etc)
  • ensure geoActivity result is preserved upon device rotation or any other non-location-changing action
  • migrate from raster to vector tiles with nice color schemes for dark/light. You can use maputnik to load the json themes for display and editing
  • Implement attribution / info

🖼️ Screenshots

🏚️ Before 🏡 After
old_light new_light2
old_dark new_dark2

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger requested a review from mahibi March 12, 2026 20:34
@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Mar 12, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from eef1c13 to cd08216 Compare March 14, 2026 13:43
@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 14, 2026
@AndyScherzinger AndyScherzinger changed the title feat: Migrate to MapLibre ⚒️🎨 Migrate to MapLibre Mar 14, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch 5 times, most recently from e13e9f9 to c13c1da Compare March 15, 2026 10:22
@AndyScherzinger AndyScherzinger marked this pull request as ready for review March 15, 2026 10:55
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from f890949 to 395700d Compare March 15, 2026 11:07
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews design Related to the design and removed 2. developing Work in progress labels Mar 15, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from 4e5bb53 to 7e7b57c Compare March 15, 2026 16:55
sowjanyakch
sowjanyakch requested changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sowjanyakch sowjanyakch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Search for a location e.g., "paris" and then press enter. Rotate the device to landscape, location is retained. Rotate the device back to portrait and then share location, UI is unresponsive.

  2. Search for a location and then press enter. The map points to the selected location but under Share this location button at the bottom, location details are not updated (in your screenshot, I see the location details).

64357

@AndyScherzinger
Copy link
Copy Markdown
Member Author

AndyScherzinger commented Mar 16, 2026 •
edited
Loading

@sowjanyakch your screenshot points to a code base before all of my changes, because

  • tiles are rastered nit vector
  • shows a scalebar, yet hidden in my update + I show an info button

So you are lacking most of the commits and hence fixes and improvements beyond the pure lib migration.

I just rebased due to latest changes on main branch, so you might want to do a fresh checkout. In short, if the map doesn't look like the screenshots on the after-column color- and sharpness-wise. Than it is not the latest code of this branch and PR.

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from 7e7b57c to a3e90b9 Compare March 16, 2026 22:02
@AndyScherzinger
feat: Migrate to MapLibre
0b7d267 
AI-assistant: Claude Code v2.1.74 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat: Migrate to vector tiles
0f7016e 
AI-assistant: Claude Code v2.1.74 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat: improve map logging and preview/message element itself, slightl…
6c040b1 
…y shorten code

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Move view-models from general package to feature-sub-package
a965ccd 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Combine init methods into a single call to the model
2402d98 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat: Hide scale bar
40550d4 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
docs: Add license files for json files
70160fc 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(lint): MapLibre pulls in Timber producing a lot of lint warnings
fc3b9d6 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(map): add proper, expanding attribution button
2fd3103 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(map): Display current location
dcc2010 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: extract keys to constants
bb8a25e 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Preserve placeName on zooming
6feede5 
(position change is smaller than COORDINATE_EPSILON translating to 0,11m)

AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: Optimize colors of dark/light map themes for better contrast
b8c9010 
AI-assistant: Copilot 1.0.5 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Fix location test
d71ae15 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: gradle formatting
e844f5b 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateToMapLibre branch from ae45f60 to e844f5b Compare March 18, 2026 06:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5962.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Mar 18, 2026

Search for a location and then press enter. The map points to the selected location but under Share this location button at the bottom, location details are not updated (in your screenshot, I see the location details).

i could bet the map was moved after coming back from the geocoding screen? As soon as the map is moved the location details are gone until the new place is actually shared. This is done to not stress the server with too many geocoding queries as we are using it for free..

@AndyScherzinger
Copy link
Copy Markdown
Member Author

AndyScherzinger commented Mar 18, 2026

This is done to not stress the server with too many geocoding queries as we are using it for free..

Yes, this. Technically we are only allowed 1 request per second overall (as in all clients together!)

@AndyScherzinger AndyScherzinger merged commit 0e489ef into master Mar 18, 2026
17 of 18 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/noid/migrateToMapLibre branch March 18, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyScherzinger @mahibi @sowjanyakch