Improve answering calls

[anakin78z]

Fixes some of the biggest annoyances with answering calls:

1. Allow answering a call from a locked phone without having to unlock the phone after answering. join call without unlock screen #1667 (kind of?)
2. Stop calls from ringing after answering. The ringing doesn't stop #5992
3. Update the incoming call notification to allow users to answer or decline. Call notification is not actually call #5922
4. Show caller avatar on incoming call notification

🖼️ Screenshots

🏚️ Before

🏡 After

🚧 TODO

There are a lot of other issues with calls. This is meant as some small changes that can have a big impact on usability.

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

Thank you for contributing @anakin78z 👍

We will review this soon (will try today but i'm on vacation next week).
As a side note, depending on if #5928 is merged first, there could be more merge conflicts.

[anakin78z]

Thanks. I'm also waiting to hear back about thstyl2000#1 since they have a massive refactor plan. I'm not sure what stage they're at with implementation though.

[mahibi]

and i oversaw it's "just" a draft for now. Just set the state when it's ready to review and let us know if you have questions.

[anakin78z]

This is what was causing the lock screen to appear after answering a call.

[anakin78z]

@mahibi It doesn't look like there would be conflicts with #5928, as my code only changes call notifications, and the bubble code seems to only affect message notifications.

[nimishavijay]

This is a great improvement! :) One design concern though is that there is not a very big difference between an audio or video call as the text says "Incoming call" for both. So some small changes to reflect that better:

• Could we change the text to "Incoming video call"?
• Could we add an icon to the the video button to indicate that the camera wold be on when you join? it could be the videocam icon

[anakin78z]

@nimishavijay Hi, thanks for the feedback.
I was actually trying to get it to do that, but it looks like the system handles the incoming call display completely. So it may look different depending on what phone you have.
I'm using NotificationCompat.CallStyle.forIncomingCall here: https://github.com/nextcloud/talk-android/pull/6015/changes#diff-b51bc8baa586c30bbd846a44639cba62c95cde0f586adb76db389f9e74635914R349 which doesn't give us any real options other than .setIsVideo().

Docs here: https://developer.android.com/reference/androidx/core/app/NotificationCompat.CallStyle#setIsVideo(boolean)

I think we would have to use a custom style to change the text or add icons, but maybe that could be a separate task, since it would involve design work?