Skip to content

⚒️🎨 Migrate room info edit to Composable#6031

Merged
AndyScherzinger merged 5 commits intomasterfrom
chore/noid/roomEditComposable
Apr 11, 2026
Merged

⚒️🎨 Migrate room info edit to Composable#6031
AndyScherzinger merged 5 commits intomasterfrom
chore/noid/roomEditComposable

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Apr 6, 2026 •
edited
Loading

  • rewrites UI to Composables
  • Improves MVVM architecture
  • Updates general room info activity UI (chat is still wrong showing the old data until you open it again)
  • Have the same 2-column layout for landscape the profile screen has

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20260406_192220 Screenshot_20260406_191815
Screenshot_20260406_192239 Screenshot_20260406_191145
Screenshot_20260406_192247 Screenshot_20260406_191158

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 24.0.0 milestone Apr 6, 2026
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews technical debt Technical issue labels Apr 6, 2026
@AndyScherzinger AndyScherzinger requested a review from mahibi April 6, 2026 17:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24042170486/artifacts/6290928138
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/roomEditComposable branch from 4c6a8b9 to dd963e0 Compare April 6, 2026 17:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24042721610/artifacts/6291086422
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/roomEditComposable branch from dd963e0 to 4293a82 Compare April 7, 2026 06:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24068300833/artifacts/6300420927
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
style: Migrate conversation editing to Composable
7306542 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Migrate to improved mvvm
51dd03e 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(temp): When returning from ConversationInfoEditActivity after a s…
d40a6b7 
…uccessful save, the activity now calls setResult(RESULT_OK) so the caller is notified of the change.

AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Further improve convo editing implementation
98909e4 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/roomEditComposable branch from 4293a82 to 98909e4 Compare April 11, 2026 08:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24278821529/artifacts/6384642389
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
test(dao): Fix dao test
d49a530 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24279830649/artifacts/6384931591
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

Codacy

Lint

TypemasterPR
Warnings8888
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5353
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8080

@AndyScherzinger AndyScherzinger merged commit 6843842 into master Apr 11, 2026
16 of 17 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/roomEditComposable branch April 11, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rapterjet2004 rapterjet2004 rapterjet2004 approved these changes

@mahibi mahibi Awaiting requested review from mahibi

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt Technical issue

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger @rapterjet2004