Skip to content

Bugfix/noid/use extra shortcut id only when supported #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahibi merged 2 commits into from
Apr 20, 2026
Merged

Bugfix/noid/use extra shortcut id only when supported #6094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4363e5d
Avoid wrong usage of EXTRA_SHORTCUT_ID
mahibi Apr 20, 2026
7c5e3b1
suppress LongParameterList for some composables
mahibi Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ class ConversationsListActivity : BaseActivity() {

// Share sheet shortcut tap: Android delivers ACTION_SEND with EXTRA_SHORTCUT_ID.
// Extract the room token from the shortcut ID so we can pre-select the conversation.
if (hasActivityActionSendIntent()) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q && hasActivityActionSendIntent()) {
val shortcutId = intent.getStringExtra(Intent.EXTRA_SHORTCUT_ID)
if (shortcutId != null) {
pendingDirectShareToken = DirectShareHelper.extractTokenFromShortcutId(shortcutId)
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/nextcloud/talk/ui/chat/ChatMessageScaffold.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ private fun ChatMessageUi.hasMentionChips(): Boolean =
message.contains("{$key}") && parameter["type"] in mentionChipTypes
}

@Suppress("Detekt.LongMethod")
@Suppress("Detekt.LongMethod", "LongParameterList")
@Composable
fun MessageScaffold(
uiMessage: ChatMessageUi,
Expand Down Expand Up @@ -313,6 +313,7 @@ private fun MessageBubbleWithReactions(
}
}

@Suppress("LongParameterList")
@Composable
private fun MessageBubbleContent(
uiMessage: ChatMessageUi,
Expand Down
Loading