add fullscreen permission setting#6128
Conversation
|
Created this PR when i was testing v23.0.1 and was wondering why the lockscreen still appeared despite of it being changed in 207f0a1. |
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/24995504699/artifacts/6660911940 |
|
Tested with 23.0.1 and confirm USE_FULL_SCREEN_INTENT is granted by default via play store install. Anyway we might have to use the fullscreen setting for the generic build (as the permission might not be granted by default when not installing via playstore). |
|
Also keep in mind when testing this with a fresh install via gplay: For the initial first time call the lockscreen may appear. This is not because of a missing fullscreen permission but for the other permissions that are required for the call. Only needs to be done one time when granting this for future uses. |
1d87506 to
51e6523
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/25810919089/artifacts/6975388661 |
feaf05b to
3f8e6d7
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/25812682113/artifacts/6976322642 |
Goal is that the call notification screen is shown without to unlock the phone. I encountered the following behavior: USE_FULL_SCREEN_INTENT is granted when running via debug in Android Studio. It is not granted when building the app and running the apk. So the unlock screen is shown instead when a call comes in. However google play console has a setting to allow USE_FULL_SCREEN_INTENT by default for this app, as it is a call app. Hopefully this will work and USE_FULL_SCREEN_INTENT is granted when installed via Google Play. However even if this works it might still make sense for the generic build variant and for f-droid to include this setting (or find another solution). Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
3f8e6d7 to
37d5e5b
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/25909117355/artifacts/7013971977 |
Add option for fullscreen permission in settings.
Necessary that the call notification screen is shown without to unlock the phone.
I encountered the following behavior:
USE_FULL_SCREEN_INTENT is granted when running via debug in Android Studio.
It is not granted when building the app and running the apk. So the unlock screen is shown instead when a call comes in.
However google play console has a setting to allow USE_FULL_SCREEN_INTENT by default for this app, as it is a call app. Hopefully this will work in v23.0.1 and USE_FULL_SCREEN_INTENT is granted when installed via Google Play.
The setting is especially useful for users who don't install via gplay.
🏁 Checklist
/backport to stable-xx.x