Skip to content

add fullscreen permission setting#6128

Merged
mahibi merged 2 commits into
masterfrom
feature/noid/fullscreenPermissionSetting
May 15, 2026
Merged

add fullscreen permission setting#6128
mahibi merged 2 commits into
masterfrom
feature/noid/fullscreenPermissionSetting

Conversation

@mahibi
Copy link
Copy Markdown
Collaborator

@mahibi mahibi commented Apr 27, 2026

Add option for fullscreen permission in settings.


Necessary that the call notification screen is shown without to unlock the phone.

I encountered the following behavior:

  • USE_FULL_SCREEN_INTENT is granted when running via debug in Android Studio.

  • It is not granted when building the app and running the apk. So the unlock screen is shown instead when a call comes in.

  • However google play console has a setting to allow USE_FULL_SCREEN_INTENT by default for this app, as it is a call app. Hopefully this will work in v23.0.1 and USE_FULL_SCREEN_INTENT is granted when installed via Google Play.

The setting is especially useful for users who don't install via gplay.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Apr 27, 2026
@mahibi
Copy link
Copy Markdown
Collaborator Author

mahibi commented Apr 27, 2026

Created this PR when i was testing v23.0.1 and was wondering why the lockscreen still appeared despite of it being changed in 207f0a1.

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24995504699/artifacts/6660911940
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
Copy link
Copy Markdown
Collaborator Author

mahibi commented Apr 27, 2026

Tested with 23.0.1 and confirm USE_FULL_SCREEN_INTENT is granted by default via play store install.

Anyway we might have to use the fullscreen setting for the generic build (as the permission might not be granted by default when not installing via playstore).

@mahibi
Copy link
Copy Markdown
Collaborator Author

mahibi commented Apr 27, 2026

Also keep in mind when testing this with a fresh install via gplay: For the initial first time call the lockscreen may appear. This is not because of a missing fullscreen permission but for the other permissions that are required for the call. Only needs to be done one time when granting this for future uses.

@mahibi mahibi force-pushed the feature/noid/fullscreenPermissionSetting branch from 1d87506 to 51e6523 Compare May 13, 2026 16:02
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25810919089/artifacts/6975388661
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi mahibi marked this pull request as ready for review May 13, 2026 16:26
@mahibi mahibi added this to the 24.0.0 milestone May 13, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label May 13, 2026
@mahibi mahibi force-pushed the feature/noid/fullscreenPermissionSetting branch from feaf05b to 3f8e6d7 Compare May 13, 2026 16:35
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25812682113/artifacts/6976322642
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

mahibi added 2 commits May 15, 2026 10:51
Goal is that the call notification screen is shown without to unlock the phone.

I encountered the following behavior:

USE_FULL_SCREEN_INTENT is granted when running via debug in Android Studio.

It is not granted when building the app and running the apk. So the unlock screen is shown instead when a call comes in.

However google play console has a setting to allow USE_FULL_SCREEN_INTENT by default for this app, as it is a call app.

Hopefully this will work and USE_FULL_SCREEN_INTENT is granted when installed via Google Play.

However even if this works it might still make sense for the generic build variant and for f-droid to include this setting (or find another solution).

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/noid/fullscreenPermissionSetting branch from 3f8e6d7 to 37d5e5b Compare May 15, 2026 08:52
@mahibi mahibi merged commit 519fa39 into master May 15, 2026
13 of 17 checks passed
@mahibi mahibi deleted the feature/noid/fullscreenPermissionSetting branch May 15, 2026 09:00
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25909117355/artifacts/7013971977
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant