Skip to content

reimplement message search#6168

Open
mahibi wants to merge 1 commit intomasterfrom
feature/6018/reimplementMessageSearch
Open

reimplement message search#6168
mahibi wants to merge 1 commit intomasterfrom
feature/6018/reimplementMessageSearch

Conversation

@mahibi
Copy link
Copy Markdown
Collaborator

@mahibi mahibi commented May 6, 2026 •
edited
Loading

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this May 6, 2026
@mahibi mahibi force-pushed the feature/6018/reimplementMessageSearch branch from bae3747 to 93b00ec Compare May 6, 2026 15:56
@mahibi mahibi marked this pull request as ready for review May 6, 2026 15:56
Copilot AI review requested due to automatic review settings May 6, 2026 15:56
@mahibi mahibi modified the milestone: 24.0.0 May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25446182834/artifacts/6835226455
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi mahibi force-pushed the feature/6018/reimplementMessageSearch branch from 93b00ec to 2dc443b Compare May 6, 2026 17:49
@mahibi mahibi added the 3. to review Waiting for reviews label May 6, 2026
@mahibi mahibi requested a review from sowjanyakch May 6, 2026 17:53
@mahibi mahibi requested a review from AndyScherzinger May 6, 2026 17:53
@mahibi mahibi requested a review from rapterjet2004 May 6, 2026 17:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25451747922/artifacts/6837617060
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
feat(chat): reimplement message search with chat block history support
63877cf 
Massive refactor of message search and chat history handling:
- Introduce three chat modes:
  * DEFAULT_MODE: Normal chat display with latest messages
  * SEARCH_MODE: In-message search functionality
  * OLD_CHATBLOCK_MODE: Display messages from past chat blocks (earlier conversations)
- Handle chatBlocks from the past:
  * Add observeMessagesForAnchor() to load historical chat blocks
  * Add getChatBlocksContainingMessageId() DAO method for anchor navigation
  * Support navigation to older messages when jumping to search results
- Unified search integration:
  * Add performUnifiedSearch() API endpoint
  * Integrate UnifiedSearchRepository into ChatViewModel
  * Enable full-text message search across conversations
- UI/UX improvements:
  * Add search bar and toolbar in ChatActivity
  * Implement search result highlighting with SearchHighlightStyle
  * Add loading indicators for search operations
  * Support for theme-aware search UI components
- Message search infrastructure:
  * Reimplement MessageSearchHelper with improved search logic
  * Enhance search result handling in search mode
  * Support search within threads and conversations
Affected components:
- ChatActivity: Added in-app search UI and mode switching
- ChatViewModel: Multi-mode message loading and search integration
- ChatRepository: New methods for historical message access
- OfflineFirstChatRepository: Chat block aware queries
- MessageSearchHelper/MessageSearchViewModel: Search implementation
- ConversationsListViewModel: Search result navigation
Co-authored by:
AI-assistant: Copilot 1.8.2 (Claude Sonnet 4.6)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/6018/reimplementMessageSearch branch from 2dc443b to 63877cf Compare May 6, 2026 19:00
@mahibi mahibi enabled auto-merge May 6, 2026 19:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/25455142092/artifacts/6839116546
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@mahibi mahibi

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

Reimplement message search

2 participants

@mahibi @rapterjet2004